Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11269008: Cache backend for devices with flash storage (Closed)

Created:
8 years, 2 months ago by agayev
Modified:
8 years, 1 month ago
CC:
chromium-reviews, sadrul, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Cache backend for devices with flash storage Fixed tests. BUG=157187 TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164064 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164133

Patch Set 1 #

Patch Set 2 : Added destructor. #

Total comments: 4

Patch Set 3 : Fixed MSVC++ compiler error. #

Patch Set 4 : Fixed nits. #

Patch Set 5 : Misc. #

Total comments: 2

Patch Set 6 : Fix Windows stack limitation problem. #

Patch Set 7 : Make Valgrind happy. #

Patch Set 8 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -136 lines) Patch
A net/disk_cache/flash/flash_cache_test_base.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A net/disk_cache/flash/flash_cache_test_base.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M net/disk_cache/flash/segment.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/disk_cache/flash/segment.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M net/disk_cache/flash/segment_unittest.cc View 1 2 3 4 5 2 chunks +95 lines, -122 lines 0 comments Download
M net/disk_cache/flash/storage_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
agayev
Since I forgot to add unit tests to net.gyp, segment tests didn't run the first ...
8 years, 2 months ago (2012-10-24 17:30:18 UTC) #1
rvargas (doing something else)
lgtm https://codereview.chromium.org/11269008/diff/3001/net/disk_cache/flash/segment_unittest.cc File net/disk_cache/flash/segment_unittest.cc (right): https://codereview.chromium.org/11269008/diff/3001/net/disk_cache/flash/segment_unittest.cc#newcode39 net/disk_cache/flash/segment_unittest.cc:39: namespace disk_cache { nit: Can this be removed ...
8 years, 2 months ago (2012-10-24 19:13:58 UTC) #2
agayev
https://codereview.chromium.org/11269008/diff/3001/net/disk_cache/flash/segment_unittest.cc File net/disk_cache/flash/segment_unittest.cc (right): https://codereview.chromium.org/11269008/diff/3001/net/disk_cache/flash/segment_unittest.cc#newcode39 net/disk_cache/flash/segment_unittest.cc:39: namespace disk_cache { On 2012/10/24 19:13:59, rvargas wrote: > ...
8 years, 2 months ago (2012-10-24 19:20:24 UTC) #3
rvargas (doing something else)
https://codereview.chromium.org/11269008/diff/3009/net/disk_cache/flash/segment_unittest.cc File net/disk_cache/flash/segment_unittest.cc (right): https://codereview.chromium.org/11269008/diff/3009/net/disk_cache/flash/segment_unittest.cc#newcode129 net/disk_cache/flash/segment_unittest.cc:129: LargeEntry entry; This is a local variable. kLargeEntrySize is ...
8 years, 1 month ago (2012-10-24 21:49:18 UTC) #4
agayev
https://codereview.chromium.org/11269008/diff/3009/net/disk_cache/flash/segment_unittest.cc File net/disk_cache/flash/segment_unittest.cc (right): https://codereview.chromium.org/11269008/diff/3009/net/disk_cache/flash/segment_unittest.cc#newcode129 net/disk_cache/flash/segment_unittest.cc:129: LargeEntry entry; On 2012/10/24 21:49:18, rvargas wrote: > This ...
8 years, 1 month ago (2012-10-24 23:44:18 UTC) #5
rvargas (doing something else)
lgtm
8 years, 1 month ago (2012-10-25 00:07:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11269008/2016
8 years, 1 month ago (2012-10-25 03:32:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11269008/2016
8 years, 1 month ago (2012-10-25 11:49:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11269008/2016
8 years, 1 month ago (2012-10-25 11:49:39 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-10-25 11:52:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11269008/2016
8 years, 1 month ago (2012-10-25 12:50:19 UTC) #11
commit-bot: I haz the power
Change committed as 164064
8 years, 1 month ago (2012-10-25 14:07:53 UTC) #12
agayev
A one line change to make valgrind bots happy, will commit now.
8 years, 1 month ago (2012-10-25 16:20:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agayev@chromium.org/11269008/28
8 years, 1 month ago (2012-10-25 16:59:30 UTC) #14
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 19:09:19 UTC) #15 
Change committed as 164133

Powered by Google App Engine
This is Rietveld 408576698