Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 11269004: Change List.sort to not have a default parameter value. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated to tup of tree. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 60c8a9e9a0c6aaee9a5ae53b9c708adec838ec42..18c6bd823aa1b19283d50d333fbbed89873b7751 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -381,7 +381,7 @@ class AnimatedLengthList implements JavaScriptIndexingBehavior, List<AnimatedLen
// From List<AnimatedLength>:
- void sort([Comparator<AnimatedLength> compare = Comparable.compare]) {
+ void sort([int compare(AnimatedLength a, AnimatedLength b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -502,7 +502,7 @@ class AnimatedNumberList implements JavaScriptIndexingBehavior, List<AnimatedNum
// From List<AnimatedNumber>:
- void sort([Comparator<AnimatedNumber> compare = Comparable.compare]) {
+ void sort([int compare(AnimatedNumber a, AnimatedNumber b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -651,7 +651,7 @@ class AnimatedTransformList implements JavaScriptIndexingBehavior, List<AnimateT
// From List<AnimateTransformElement>:
- void sort([Comparator<AnimateTransformElement> compare = Comparable.compare]) {
+ void sort([int compare(AnimateTransformElement a, AnimateTransformElement b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -3052,7 +3052,7 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
// From List<Length>:
- void sort([Comparator<Length> compare = Comparable.compare]) {
+ void sort([int compare(Length a, Length b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -3566,7 +3566,7 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
// From List<Number>:
- void sort([Comparator<Number> compare = Comparable.compare]) {
+ void sort([int compare(Number a, Number b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -4259,7 +4259,7 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
// From List<PathSeg>:
- void sort([Comparator<PathSeg> compare = Comparable.compare]) {
+ void sort([int compare(PathSeg a, PathSeg b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -4970,7 +4970,7 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
// From List<String>:
- void sort([Comparator<String> compare = Comparable.compare]) {
+ void sort([int compare(String a, String b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -5948,7 +5948,7 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
// From List<Transform>:
- void sort([Comparator<Transform> compare = Comparable.compare]) {
+ void sort([int compare(Transform a, Transform b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}
@@ -6346,7 +6346,7 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
// From List<ElementInstance>:
- void sort([Comparator<ElementInstance> compare = Comparable.compare]) {
+ void sort([int compare(ElementInstance a, ElementInstance b)]) {
throw new UnsupportedError("Cannot sort immutable List.");
}

Powered by Google App Engine
This is Rietveld 408576698