Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.h

Issue 11269002: Introduce GeolocationPermissionRequestID, a wrapper struct to contain the (render process ID, rende… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/geolocation/chrome_geolocation_permission_context.h
===================================================================
--- chrome/browser/geolocation/chrome_geolocation_permission_context.h (revision 163741)
+++ chrome/browser/geolocation/chrome_geolocation_permission_context.h (working copy)
@@ -11,6 +11,7 @@
#include "chrome/browser/geolocation/geolocation_infobar_queue_controller.h"
#include "content/public/browser/geolocation_permission_context.h"
+class GeolocationPermissionRequestID;
class Profile;
// Chrome specific implementation of GeolocationPermissionContext; manages
@@ -21,7 +22,7 @@
public:
explicit ChromeGeolocationPermissionContext(Profile* profile);
- // GeolocationPermissionContext implementation:
+ // GeolocationPermissionContext:
virtual void RequestGeolocationPermission(
int render_process_id,
int render_view_id,
@@ -47,9 +48,7 @@
// geolocation via
// GeolocationPermissionContext::SetGeolocationPermissionResponse().
// Called on the UI thread.
- void NotifyPermissionSet(int render_process_id,
- int render_view_id,
- int bridge_id,
+ void NotifyPermissionSet(const GeolocationPermissionRequestID& id,
const GURL& requesting_frame,
base::Callback<void(bool)> callback,
bool allowed);
@@ -59,9 +58,7 @@
// Calls PermissionDecided if permission can be decided non-interactively,
// or NotifyPermissionSet if permission decided by presenting an
// infobar to the user. Called on the UI thread.
- virtual void DecidePermission(int render_process_id,
- int render_view_id,
- int bridge_id,
+ virtual void DecidePermission(const GeolocationPermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
base::Callback<void(bool)> callback);
@@ -70,9 +67,7 @@
// the user. Can be overridden to introduce additional UI flow.
// Should ultimately ensure that NotifyPermissionSet is called.
// Called on the UI thread.
- virtual void PermissionDecided(int render_process_id,
- int render_view_id,
- int bridge_id,
+ virtual void PermissionDecided(const GeolocationPermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
base::Callback<void(bool)> callback,
@@ -84,9 +79,7 @@
private:
// Removes any pending InfoBar request.
- void CancelPendingInfoBarRequest(int render_process_id,
- int render_view_id,
- int bridge_id);
+ void CancelPendingInfoBarRequest(const GeolocationPermissionRequestID& id);
// This must only be accessed from the UI thread.
Profile* const profile_;
« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698