Introduce GeolocationPermissionRequestID, a wrapper struct to contain the (render process ID, rende…

content/public/browser/geolocation.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_GEOLOCATION_H_
 #define CONTENT_PUBLIC_BROWSER_GEOLOCATION_H_
 
+#include <string>
+
 #include "base/callback_forward.h"
 #include "content/common/content_export.h"
 
 namespace content {
 
 struct Geoposition;
 
 typedef base::Callback<void(const Geoposition&)> GeolocationUpdateCallback;
 
+// Uniquely identifies a particular geolocation permission request.
+struct CONTENT_EXPORT GeolocationPermissionRequestID {
+  GeolocationPermissionRequestID(int render_process_id,
+                                 int render_view_id,
+                                 int bridge_id);
+
+  bool Equals(const GeolocationPermissionRequestID& other) const;

[Jói, 2012/10/24 09:48:36]

I think our coding style only allows constructor, "Init" and "Reset" type
functions on a struct; should this be a class instead?

Personally I think it's fine this way and I'm not 100% sure on the coding style
question, so will give my LGTM for this set-up.

[jam, 2012/10/24 16:39:43]

you're right, the style guide is specific that if there are functions other than
init/reset it should be a class. personally i think this complicates scenarios
like this, but I think we should follow the style guide.

nit: why Equals instead of operator==?

+  bool IsForSameTabAs(const GeolocationPermissionRequestID& other) const;
+  std::string ToString() const;
+
+  int render_process_id;
+  int render_view_id;
+  int bridge_id;
+};
+
 // Overrides the current location for testing. This function may be called on
 // any thread. The completion callback will be invoked asynchronously on the
 // calling thread when the override operation is completed.
 //
 // This function allows the current location to be faked without having to
 // manually instantiate a GeolocationProvider backed by a MockLocationProvider
 // that serves a fake location.
 //
 // Do not use this function in unit tests. The function instantiates the
 // singleton geolocation stack in the background and manipulates it to report
 // a fake location. Neither step can be undone, breaking unit test isolation
 // (crbug.com/125931).
 void CONTENT_EXPORT OverrideLocationForTesting(
     const Geoposition& position,
     const base::Closure& completion_callback);
 
 // Requests a one-time callback when the next location update becomes available.
 // This function may be called on any thread. The callback will be invoked on
 // the calling thread.
 void CONTENT_EXPORT RequestLocationUpdate(
     const GeolocationUpdateCallback& callback);
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_GEOLOCATION_H_