Cast: Enable high-resolution timers while casting.

Cast: Enable high-resolution timers while casting.

Committed: https://crrev.com/66e437031fab7d461eca47dec31e561d42768711
Cr-Commit-Position: refs/heads/master@{#328870}

[hubbe, 2015-05-06 20:34:12]

hubbe@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2015-05-07 02:58:00]

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
File chrome/renderer/media/cast_receiver_session_delegate.cc (right):

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
chrome/renderer/media/cast_receiver_session_delegate.cc:14:
base::Time::ActivateHighResolutionTimer(true);
Consider adding a LOG(WARNING) message if this function returns false.

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
chrome/renderer/media/cast_receiver_session_delegate.cc:14:
base::Time::ActivateHighResolutionTimer(true);
Also, should all these code changes go in CastSessionDelegateBase so that both a
sender and receiver gets high-res timers?  Or, did you evaluate that the sender
doesn't need high-res timers?

[hubbe, 2015-05-07 19:16:50]

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
File chrome/renderer/media/cast_receiver_session_delegate.cc (right):

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
chrome/renderer/media/cast_receiver_session_delegate.cc:14:
base::Time::ActivateHighResolutionTimer(true);
On 2015/05/07 02:58:00, miu wrote:
> Consider adding a LOG(WARNING) message if this function returns false.

Done.

https://codereview.chromium.org/1126873002/diff/40001/chrome/renderer/media/c...
chrome/renderer/media/cast_receiver_session_delegate.cc:14:
base::Time::ActivateHighResolutionTimer(true);
On 2015/05/07 02:58:00, miu wrote:
> Also, should all these code changes go in CastSessionDelegateBase so that both
a
> sender and receiver gets high-res timers?  Or, did you evaluate that the
sender
> doesn't need high-res timers?

No thinking, I just put it in the wrong place. :)

[miu, 2015-05-07 20:04:34]

lgtm % one nit:

https://codereview.chromium.org/1126873002/diff/80001/chrome/renderer/media/c...
File chrome/renderer/media/cast_session_delegate.cc (right):

https://codereview.chromium.org/1126873002/diff/80001/chrome/renderer/media/c...
chrome/renderer/media/cast_session_delegate.cc:41: if
(!base::Time::ActivateHighResolutionTimer(true)) {
nit: This led me to think this only provides better time precision on the "old
machines."  But, as we discussed, it also affects the threading timeslices.  Can
you add a quick comment to that effect here?

[hubbe, 2015-05-07 21:04:00]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2015-05-07 21:04:00]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1126873002/#ps60002
(title: "comment added")

[commit-bot: I haz the power, 2015-05-07 21:09:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126873002/60002

[commit-bot: I haz the power, 2015-05-07 23:06:02]

Committed patchset #6 (id:60002)

[commit-bot: I haz the power, 2015-05-07 23:06:53]

Patchset 6 (id:??) landed as
https://crrev.com/66e437031fab7d461eca47dec31e561d42768711
Cr-Commit-Position: refs/heads/master@{#328870}