Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 112683004: Bounds fixes for SkXfermodeImageFilter: (Closed)

Created:
7 years ago by Stephen White
Modified:
7 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Bounds fixes for SkXfermodeImageFilter: 1) Change the default bounds to the union of the foreground and background bounds. 2) Use a canvas translate instead of manually offsetting the foreground and background bounds by the union. 3) Apply the transfer mode to all pixels, including those outside the foreground rect by using a difference clip. Covered by the offset test cases in the xfermodeimagefilter GM (will need rebaselines). R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12652

Patch Set 1 #

Patch Set 2 : Add comment to ignored-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
reed@: PTAL. Thanks!
7 years ago (2013-12-12 15:34:51 UTC) #1
reed1
lgtm
7 years ago (2013-12-12 16:32:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/112683004/20001
7 years ago (2013-12-12 17:12:08 UTC) #3
Stephen White
7 years ago (2013-12-12 21:01:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r12652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698