|
|
Created:
5 years, 7 months ago by no sievers Modified:
5 years, 7 months ago CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRun webgl_conformance with the Android WebView shell
This adds a build step to run conformance with the
webview shell, which exercises very different codepaths
NOTRY=True (There are no trybots for this)
BUG=420707
R=kbr@chromium.org, navabi@chromium.org, navabi@google.com
Committed: https://chromium.googlesource.com/chromium/src/+/f3abeea37887a3e4fa22060c3683304bcc93c06b
Patch Set 1 #
Messages
Total messages: 23 (5 generated)
sievers@chromium.org changed reviewers: + boliu@chromium.org, kbr@chromium.org
Like this?
I'm assuming that's right. Does that bot already build the necessary target? LGTM if so.
On 2015/05/05 19:16:44, Ken Russell wrote: > I'm assuming that's right. Does that bot already build the necessary target? > LGTM if so. I think so. I see android_webview_apk stuff being built in the log frmo the GPU bot. Since the bot just seems to be building the default, I assume it comes from the 'All' target where 'android_webview_apk' is listed.
sievers@chromium.org changed reviewers: + navabi@chromium.org
+Armand for OWNERS
navabi@google.com changed reviewers: + navabi@google.com
rubber stamp lgtm
rubber stamp lgtm
rubber stamp lgtm
The CQ bit was checked by sievers@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126793005/1
The CQ bit was unchecked by sievers@chromium.org
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f3abeea37887a3e4fa22060c3683304bcc93c06b Cr-Commit-Position: refs/heads/master@{#328389}
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as f3abeea37887a3e4fa22060c3683304bcc93c06b (presubmit successful).
Message was sent while issue was closed.
LGTM \o/
Message was sent while issue was closed.
That is totally failing to run: > content/test/gpu/run_gpu_test.py --browser=android-webview-shell webgl_conformance --webgl-conformance-version=1.0.1 WARNING:root:Installing ./out/Debug/apks/AndroidWebView.apk on device if needed. [ RUN ] WebglConformance.conformance_attribs_gl_enable_vertex_attrib WARNING:root:Web Page Replay requires SNI support (pyOpenSSL 0.13 or greater) to generate certificates from a test CA. Will fallback to ignoring certificate errors. CRITICAL:root:******************************************************************************** CRITICAL:root:Stack dump for thread 'TimeoutThread-1-for-MainThread' CRITICAL:root:******************************************************************************** CRITICAL:root:File: "/usr/lib/python2.7/threading.py", line 524, in __bootstrap CRITICAL:root: self.__bootstrap_inner() CRITICAL:root:File: "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner CRITICAL:root: self.run() CRITICAL:root:File: "/b/build/slave/Android_Debug__Nexus_7_/build/src/build/android/pylib/utils/reraiser_thread.py", line 76, in run CRITICAL:root: self._ret = self._func(*self._args, **self._kwargs) CRITICAL:root:File: "/b/build/slave/Android_Debug__Nexus_7_/build/src/build/android/pylib/utils/timeout_retry.py", line 150, in RunOnTimeoutThread CRITICAL:root: ret[0] = func(*args, **kwargs) CRITICAL:root:File: "/b/build/slave/Android_Debug__Nexus_7_/build/src/build/android/pylib/device/decorators.py", line 51, in impl
Message was sent while issue was closed.
Is the webview apk installed..?
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1119283005/ by sievers@chromium.org. The reason for reverting is: Doesn't work on the bot. Works locally. No idea..
Message was sent while issue was closed.
On 2015/05/05 21:39:31, boliu wrote: > Is the webview apk installed..? > WARNING:root:Installing ./out/Debug/apks/AndroidWebView.apk on device if needed.
Message was sent while issue was closed.
Jellybean device?! :( 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: java.lang.NoSuchMethodError: android.view.ViewGroup.isAttachedToWindow 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at org.chromium.android_webview.AwContents.onContainerViewChanged(AwContents.java:839) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at org.chromium.android_webview.AwContents.<init>(AwContents.java:701) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at org.chromium.android_webview.AwContents.<init>(AwContents.java:628) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at org.chromium.android_webview.shell.AwShellActivity.createAwTestContainerView(AwShellActivity.java:165) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at org.chromium.android_webview.shell.AwShellActivity.onCreate(AwShellActivity.java:74) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:5133) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2175) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2261) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.ActivityThread.access$600(ActivityThread.java:141) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.os.Looper.loop(Looper.java:137) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:5103) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at java.lang.reflect.Method.invokeNative(Native Method) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at java.lang.reflect.Method.invoke(Method.java:525) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at dalvik.system.NativeStart.main(Native Method) 00a08: 05-05 21:32:05.770 452 735 W ActivityManager: Force finishing activity org.chromium.android_webview.shell/.AwShellActivity
Message was sent while issue was closed.
On 2015/05/05 21:46:52, boliu wrote: > Jellybean device?! :( > > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: > java.lang.NoSuchMethodError: android.view.ViewGroup.isAttachedToWindow > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > org.chromium.android_webview.AwContents.onContainerViewChanged(AwContents.java:839) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > org.chromium.android_webview.AwContents.<init>(AwContents.java:701) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > org.chromium.android_webview.AwContents.<init>(AwContents.java:628) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > org.chromium.android_webview.shell.AwShellActivity.createAwTestContainerView(AwShellActivity.java:165) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > org.chromium.android_webview.shell.AwShellActivity.onCreate(AwShellActivity.java:74) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.Activity.performCreate(Activity.java:5133) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2175) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2261) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.ActivityThread.access$600(ActivityThread.java:141) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.os.Handler.dispatchMessage(Handler.java:99) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.os.Looper.loop(Looper.java:137) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > android.app.ActivityThread.main(ActivityThread.java:5103) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > java.lang.reflect.Method.invokeNative(Native Method) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > java.lang.reflect.Method.invoke(Method.java:525) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) > 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: at > dalvik.system.NativeStart.main(Native Method) > 00a08: 05-05 21:32:05.770 452 735 W ActivityManager: Force finishing > activity org.chromium.android_webview.shell/.AwShellActivity Yea, but I didn't think that would matter.
Message was sent while issue was closed.
Relanded in https://codereview.chromium.org/1121893003/ after bot update to Android K. |