Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1126793005: Run webgl_conformance with the Android WebView shell (Closed)

Created:
5 years, 7 months ago by no sievers
Modified:
5 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run webgl_conformance with the Android WebView shell This adds a build step to run conformance with the webview shell, which exercises very different codepaths NOTRY=True (There are no trybots for this) BUG=420707 R=kbr@chromium.org, navabi@chromium.org, navabi@google.com Committed: https://chromium.googlesource.com/chromium/src/+/f3abeea37887a3e4fa22060c3683304bcc93c06b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (5 generated)
no sievers
Like this?
5 years, 7 months ago (2015-05-05 18:59:23 UTC) #2
Ken Russell (switch to Gerrit)
I'm assuming that's right. Does that bot already build the necessary target? LGTM if so.
5 years, 7 months ago (2015-05-05 19:16:44 UTC) #3
no sievers
On 2015/05/05 19:16:44, Ken Russell wrote: > I'm assuming that's right. Does that bot already ...
5 years, 7 months ago (2015-05-05 19:19:57 UTC) #4
no sievers
+Armand for OWNERS
5 years, 7 months ago (2015-05-05 19:34:17 UTC) #6
navabi
rubber stamp lgtm
5 years, 7 months ago (2015-05-05 19:42:24 UTC) #8
navabi1
rubber stamp lgtm
5 years, 7 months ago (2015-05-05 19:42:45 UTC) #9
navabi1
rubber stamp lgtm
5 years, 7 months ago (2015-05-05 19:42:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126793005/1
5 years, 7 months ago (2015-05-05 19:44:49 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3abeea37887a3e4fa22060c3683304bcc93c06b Cr-Commit-Position: refs/heads/master@{#328389}
5 years, 7 months ago (2015-05-05 20:04:06 UTC) #14
no sievers
Committed patchset #1 (id:1) manually as f3abeea37887a3e4fa22060c3683304bcc93c06b (presubmit successful).
5 years, 7 months ago (2015-05-05 20:04:20 UTC) #15
boliu
LGTM \o/
5 years, 7 months ago (2015-05-05 20:05:09 UTC) #16
no sievers
That is totally failing to run: > content/test/gpu/run_gpu_test.py --browser=android-webview-shell webgl_conformance --webgl-conformance-version=1.0.1 WARNING:root:Installing ./out/Debug/apks/AndroidWebView.apk on device ...
5 years, 7 months ago (2015-05-05 21:34:31 UTC) #17
boliu
Is the webview apk installed..?
5 years, 7 months ago (2015-05-05 21:39:31 UTC) #18
no sievers
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1119283005/ by sievers@chromium.org. ...
5 years, 7 months ago (2015-05-05 21:40:01 UTC) #19
no sievers
On 2015/05/05 21:39:31, boliu wrote: > Is the webview apk installed..? > WARNING:root:Installing ./out/Debug/apks/AndroidWebView.apk on ...
5 years, 7 months ago (2015-05-05 21:41:23 UTC) #20
boliu
Jellybean device?! :( 00a08: 05-05 21:32:05.760 6871 6871 E AndroidRuntime: java.lang.NoSuchMethodError: android.view.ViewGroup.isAttachedToWindow 00a08: 05-05 21:32:05.760 ...
5 years, 7 months ago (2015-05-05 21:46:52 UTC) #21
no sievers
On 2015/05/05 21:46:52, boliu wrote: > Jellybean device?! :( > > 00a08: 05-05 21:32:05.760 6871 ...
5 years, 7 months ago (2015-05-05 21:47:49 UTC) #22
no sievers
5 years, 7 months ago (2015-05-06 00:40:26 UTC) #23
Message was sent while issue was closed.
Relanded in https://codereview.chromium.org/1121893003/ after bot update to
Android K.

Powered by Google App Engine
This is Rietveld 408576698