cc: Make tiling interest rect calc based on viewport.

cc/resources/tile_manager_unittest.cc

Index: cc/resources/tile_manager_unittest.cc
diff --git a/cc/resources/tile_manager_unittest.cc b/cc/resources/tile_manager_unittest.cc
index acd3a740bb3c84cb67966762fc6231b77b643739..259270cf59a8556dcbce14c7d80287bba40d1b00 100644
--- a/cc/resources/tile_manager_unittest.cc
+++ b/cc/resources/tile_manager_unittest.cc
@@ -775,8 +775,8 @@ TEST_F(TileManagerTilePriorityQueueTest, EvictionTilePriorityQueue) {
   }
 
   // Ensure that the distance is decreasing many more times than increasing.
-  EXPECT_EQ(3, distance_increasing);
-  EXPECT_EQ(17, distance_decreasing);
+  EXPECT_EQ(0, distance_increasing);
+  EXPECT_EQ(8, distance_decreasing);

[vmpstr, 2015/05/06 17:57:29]

I'd prefer if these numbers stayed the same, can you adjust the multiplier so
that the same amount of tiles is created instead?

[sohanjg, 2015/05/07 14:42:10]

Hmm..we cant modify the LayerTreeSettings from this test, and we are not
explicitly creating PLTS, to pass the multiplier :/

any suggestions ?

[vmpstr, 2015/05/07 17:21:38]

host_impl that is constructed for this test takes a LayerTreeSettings. Does
setting the multiplier to be high for all tests here work?

[sohanjg, 2015/05/08 13:26:09]

Done.

Works fine, thanks  :)

   EXPECT_EQ(tile_count, smoothness_tiles.size());
   EXPECT_EQ(all_tiles, smoothness_tiles);
 
@@ -815,8 +815,8 @@ TEST_F(TileManagerTilePriorityQueueTest, EvictionTilePriorityQueue) {
   }
 
   // Ensure that the distance is decreasing many more times than increasing.
-  EXPECT_EQ(3, distance_increasing);
-  EXPECT_EQ(17, distance_decreasing);
+  EXPECT_EQ(0, distance_increasing);
+  EXPECT_EQ(8, distance_decreasing);

[vmpstr, 2015/05/06 17:57:29]

Same here.

[sohanjg, 2015/05/07 14:42:10]

Acknowledged.

[sohanjg, 2015/05/08 13:26:09]

Done.

   EXPECT_EQ(tile_count, new_content_tiles.size());
   EXPECT_EQ(all_tiles, new_content_tiles);
 }
@@ -1176,10 +1176,10 @@ TEST_F(TileManagerTilePriorityQueueTest,
 
   client.SetTileSize(gfx::Size(30, 30));
   LayerTreeSettings settings;
-  settings.max_tiles_for_interest_area = 10000;
+  settings.tiling_interest_area_viewport_multiplier = 36;

[vmpstr, 2015/05/06 17:57:29]

These numbers seem pretty random, why 36? Before it was 10000 to say
"everything" basically, but 36 seems awfully specific.

[sohanjg, 2015/05/07 14:42:10]

Done.

I tried to keep the interest rect same as before in the test.
It was 10000 X 30 X 30, viewport here is 500 X 500, so i kept it 36 to be same
as before. But, 10000 should pass too, i'll change it.

 
   scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create(
-      ACTIVE_TREE, &client, settings.max_tiles_for_interest_area,
+      ACTIVE_TREE, &client, settings.tiling_interest_area_viewport_multiplier,
       settings.skewport_target_time_in_seconds,
       settings.skewport_extrapolation_limit_in_content_pixels);
 
@@ -1286,10 +1286,10 @@ TEST_F(TileManagerTilePriorityQueueTest,
 
   client.SetTileSize(gfx::Size(30, 30));
   LayerTreeSettings settings;
-  settings.max_tiles_for_interest_area = 10000;
+  settings.tiling_interest_area_viewport_multiplier = 180;
 
   scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create(
-      ACTIVE_TREE, &client, settings.max_tiles_for_interest_area,
+      ACTIVE_TREE, &client, settings.tiling_interest_area_viewport_multiplier,
       settings.skewport_target_time_in_seconds,
       settings.skewport_extrapolation_limit_in_content_pixels);