Introduce RegistrationServer.

client/registration_request_win.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.

[Mark Mentovai, 2015/05/05 20:20:32]

This would be easier to review with --no-find-copies.

[Mark Mentovai, 2015/05/05 20:20:32]

Headers should be listed in the .gyp file too.

 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "test/paths.h"
+#ifndef CRASHPAD_CLIENT_REGISTRATION_REQUEST_WIN_H_
+#define CRASHPAD_CLIENT_REGISTRATION_REQUEST_WIN_H_
 
 #include <windows.h>
 
 namespace crashpad {
-namespace test {
 
-// static
-base::FilePath Paths::Executable() {
-  wchar_t executable_path[_MAX_PATH];
-  GetModuleFileName(nullptr, executable_path, sizeof(executable_path));
-  return base::FilePath(executable_path);
-}
+struct RegistrationRequest {

[Mark Mentovai, 2015/05/05 20:20:32]

Ideally, everything in namespace crashpad has Doxygen comments.

+  DWORD client_process_id;
+  size_t crashpad_info_address;

[Mark Mentovai, 2015/05/05 20:20:33]

This may pose a problem for future cross-bitted operation. (And if you did use
size_t, you’d need to #include <sys/types.h>.)

+};
 
-}  // namespace test
 }  // namespace crashpad
+
+#endif  // CRASHPAD_CLIENT_REGISTRATION_REQUEST_WIN_H_