Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1126763002: Revert of Convert SpdyNetworkTransactionTest to SequencedSocketData. (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert SpdyNetworkTransactionTest to SequencedSocketData. (patchset #6 id:120001 of https://codereview.chromium.org/1114213005/) Reason for revert: Stop 2 on the revert train. Next stop, fixed net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1)? https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg) Original issue's description: > Convert SpdyNetworkTransactionTest to SequencedSocketData. > > Reduces runtime to 11 seconds from 59 seconds on my linux workstation. > There are still a number of tests which have not been unconverted because they make use of "CompleteRead" semantics which I still need to implement in SequencedSocketData. > > BUG=332112 > > Committed: https://crrev.com/73e1742f4729161d16f70cbdad9d4c1c1836be52 > Cr-Commit-Position: refs/heads/master@{#328171} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=332112 Committed: https://crrev.com/ba88353a45b46f2ea4383d4a9fee258156a37571 Cr-Commit-Position: refs/heads/master@{#328269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+771 lines, -684 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 118 chunks +771 lines, -684 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Convert SpdyNetworkTransactionTest to SequencedSocketData.
5 years, 7 months ago (2015-05-05 03:36:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126763002/1
5 years, 7 months ago (2015-05-05 03:36:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 03:37:58 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 03:38:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba88353a45b46f2ea4383d4a9fee258156a37571
Cr-Commit-Position: refs/heads/master@{#328269}

Powered by Google App Engine
This is Rietveld 408576698