Make calls to AtomicString(const String&) explicit in modules/websockets/

Make calls to AtomicString(const String&) explicit in modules/websockets/

Make calls to AtomicString(const String&) explicit in modules/websockets/.

This is one step towards making the AtomicString(const String&) constructor
explicit. This CL takes care only of the html/ part so that it is more
easily reviewable.

R=eseidel, yhirano@chromium.org
BUG=323739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164410

[eseidel, 2013-12-31 23:12:13]

I really hope there is a perf win here, otherwise all this tossing in
turning is somewhat hard to stomach.

lgtm.

On Tue, Dec 31, 2013 at 1:36 PM,  <ch.dumez@samsung.com> wrote:
> Reviewers: eseidel, yhirano,
>
> Description:
> Make calls to AtomicString(const String&) explicit in modules/websockets/
>
> Make calls to AtomicString(const String&) explicit in modules/websockets/.
>
> This is one step towards making the AtomicString(const String&) constructor
> explicit. This CL takes care only of the html/ part so that it is more
> easily reviewable.
>
> R=eseidel, yhirano@chromium.org
> BUG=323739
>
> Please review this at https://codereview.chromium.org/112673007/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+8, -8 lines):
>   M Source/modules/websockets/WebSocketHandshake.cpp
>
>
> Index: Source/modules/websockets/WebSocketHandshake.cpp
> diff --git a/Source/modules/websockets/WebSocketHandshake.cpp
> b/Source/modules/websockets/WebSocketHandshake.cpp
> index
>
b0ed328eb15260c46a096eeea958649db3264814..9d52c9fbf743d327d3cb1661692059e52cf91cfc
> 100644
> --- a/Source/modules/websockets/WebSocketHandshake.cpp
> +++ b/Source/modules/websockets/WebSocketHandshake.cpp
> @@ -256,31 +256,31 @@ PassRefPtr<WebSocketHandshakeRequest>
> WebSocketHandshake::clientHandshakeRequest
>      RefPtr<WebSocketHandshakeRequest> request =
> WebSocketHandshakeRequest::create("GET", m_url);
>      request->addHeaderField("Upgrade", "websocket");
>      request->addHeaderField("Connection", "Upgrade");
> -    request->addHeaderField("Host", hostName(m_url, m_secure));
> -    request->addHeaderField("Origin", clientOrigin());
> +    request->addHeaderField("Host", AtomicString(hostName(m_url,
> m_secure)));
> +    request->addHeaderField("Origin", AtomicString(clientOrigin()));
>      if (!m_clientProtocol.isEmpty())
> -        request->addHeaderField("Sec-WebSocket-Protocol",
> m_clientProtocol);
> +        request->addHeaderField("Sec-WebSocket-Protocol",
> AtomicString(m_clientProtocol));
>
>      KURL url = httpURLForAuthenticationAndCookies();
>      if (m_context->isDocument()) {
>          Document* document = toDocument(m_context);
>          String cookie = cookieRequestHeaderFieldValue(document, url);
>          if (!cookie.isEmpty())
> -            request->addHeaderField("Cookie", cookie);
> +            request->addHeaderField("Cookie", AtomicString(cookie));
>          // Set "Cookie2: <cookie>" if cookies 2 exists for url?
>      }
>
>      request->addHeaderField("Pragma", "no-cache");
>      request->addHeaderField("Cache-Control", "no-cache");
>
> -    request->addHeaderField("Sec-WebSocket-Key", m_secWebSocketKey);
> +    request->addHeaderField("Sec-WebSocket-Key",
> AtomicString(m_secWebSocketKey));
>      request->addHeaderField("Sec-WebSocket-Version", "13");
>      const String extensionValue =
> m_extensionDispatcher.createHeaderValue();
>      if (extensionValue.length())
> -        request->addHeaderField("Sec-WebSocket-Extensions",
> extensionValue);
> +        request->addHeaderField("Sec-WebSocket-Extensions",
> AtomicString(extensionValue));
>
>      // Add a User-Agent header.
> -    request->addHeaderField("User-Agent",
> m_context->userAgent(m_context->url()));
> +    request->addHeaderField("User-Agent",
> AtomicString(m_context->userAgent(m_context->url())));
>
>      return request.release();
>  }
> @@ -520,7 +520,7 @@ const char* WebSocketHandshake::readHTTPHeaders(const
> char* start, const char* e
>
>      String extensions = m_extensionDispatcher.acceptedExtensions();
>      if (!extensions.isEmpty())
> -        m_response.addHeaderField("Sec-WebSocket-Extensions", extensions);
> +        m_response.addHeaderField("Sec-WebSocket-Extensions",
> AtomicString(extensions));
>      return p;
>  }
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-01 16:01:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/112673007/1

[commit-bot: I haz the power, 2014-01-01 16:07:49]

Change committed as 164410