Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 1126723004: small cleanup in GrOvalRenderer (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

small cleanup in GrOvalRenderer BUG=skia: Committed: https://skia.googlesource.com/skia/+/d96a67bcb196aa4f73ff773bd45810a94ca872d8

Patch Set 1 #

Patch Set 2 : Simple fix for oval #

Patch Set 3 : tidy #

Patch Set 4 : tidy #

Total comments: 1

Patch Set 5 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -49 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 23 chunks +31 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, this CL also changes us to prefer ellipse to dieelipse if we can.
5 years, 7 months ago (2015-05-05 18:38:21 UTC) #2
bsalomon
otherwise lgtm https://codereview.chromium.org/1126723004/diff/60001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/1126723004/diff/60001/src/gpu/GrOvalRenderer.cpp#newcode672 src/gpu/GrOvalRenderer.cpp:672: return this->drawEllipse(target, pipelineBuilder, color, viewMatrix, useCoverageAA, oval, ...
5 years, 7 months ago (2015-05-05 20:52:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126723004/80001
5 years, 7 months ago (2015-05-05 20:58:10 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 21:09:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d96a67bcb196aa4f73ff773bd45810a94ca872d8

Powered by Google App Engine
This is Rietveld 408576698