Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11267043: Small IL cleanup. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 14070)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -1081,15 +1081,6 @@
MethodRecognizer::Kind recognized_kind =
MethodRecognizer::RecognizeKind(target);
- if ((recognized_kind == MethodRecognizer::kDoubleToDouble) &&
- (class_ids[0] == kDoubleCid)) {
- DoubleToDoubleInstr* d2d_instr =
- new DoubleToDoubleInstr(call->ArgumentAt(0)->value(), call);
- call->ReplaceWith(d2d_instr, current_iterator());
- RemovePushArguments(call);
- return true;
- }
-
if ((recognized_kind == MethodRecognizer::kIntegerToDouble) &&
(class_ids[0] == kSmiCid)) {
SmiToDoubleInstr* s2d_instr = new SmiToDoubleInstr(call);
@@ -1099,21 +1090,6 @@
return true;
}
- const intptr_t cid0 = class_ids[0];
- if ((recognized_kind == MethodRecognizer::kIntegerToInteger) &&
- ((cid0 == kSmiCid) || (cid0 == kMintCid) || (cid0 == kBigintCid))) {
- // TODO(srdjan): implement also for mixed integer cids.
- InsertBefore(call,
- new CheckSmiInstr(call->ArgumentAt(0)->value()->Copy(),
- call->deopt_id()),
- call->env(),
- Definition::kEffect);
- call->ReplaceUsesWith(call->ArgumentAt(0));
- RemovePushArguments(call);
- call->RemoveFromGraph();
- return true;
- }
-
if ((recognized_kind == MethodRecognizer::kDoubleToInteger) &&
(class_ids[0] == kDoubleCid)) {
AddCheckClass(call, call->ArgumentAt(0)->value()->Copy());
@@ -3308,17 +3284,6 @@
}
-void ConstantPropagator::VisitDoubleToDouble(DoubleToDoubleInstr* instr) {
- const Object& value = instr->value()->definition()->constant_value();
- if (IsNonConstant(value)) {
- SetValue(instr, non_constant_);
- } else if (IsConstant(value)) {
- // TODO(kmillikin): Handle conversion.
- SetValue(instr, non_constant_);
- }
-}
-
-
void ConstantPropagator::VisitSmiToDouble(SmiToDoubleInstr* instr) {
// TODO(kmillikin): Handle conversion.
SetValue(instr, non_constant_);
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698