Issue 1126703005: Fix ASAN build in GN.

Issue 1126703005: Fix ASAN build in GN. (Closed)

Created:
5 years, 7 months ago by jam

Modified:
5 years, 7 months ago

Reviewers:
brettw, Ben Goodger (Google)

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix ASAN build in GN. Also add missing dependency in mandoline. Committed: https://crrev.com/7080a81857e6a5be8eed11942ead222e98e5b34f Cr-Commit-Position: refs/heads/master@{#328396}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -0 lines)			Patch
M	build/config/sanitizers/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mandoline/ui/aura/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/yasm/BUILD.gn	View	7 chunks	+17 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

jam

Ben: mandoline Brett: the rest. Is there a better way of putting the deps line ...

5 years, 7 months ago (2015-05-05 18:16:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126703005/1

5 years, 7 months ago (2015-05-05 20:36:32 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-05 20:41:07 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7080a81857e6a5be8eed11942ead222e98e5b34f
Cr-Commit-Position: refs/heads/master@{#328396}