Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/installer/util/master_preferences.cc

Issue 11267023: Implementing --app-launcher install/uninstall flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing shortcut install (will do in different CL), but keeping some refactoring. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/master_preferences.cc
diff --git a/chrome/installer/util/master_preferences.cc b/chrome/installer/util/master_preferences.cc
index d397b8c3dfcd701722fa9ee583d1ba545080d230..f8fcf65c2e058f0e7f818b6f118c1f177c49ff4c 100644
--- a/chrome/installer/util/master_preferences.cc
+++ b/chrome/installer/util/master_preferences.cc
@@ -98,8 +98,11 @@ MasterPreferences::MasterPreferences(const CommandLine& cmd_line)
}
MasterPreferences::MasterPreferences(const FilePath& prefs_path)
- : distribution_(NULL), preferences_read_from_file_(false),
- chrome_(true), chrome_app_host_(false), chrome_frame_(false),
+ : distribution_(NULL),
+ preferences_read_from_file_(false),
+ chrome_(true),
+ chrome_app_host_(false),
+ chrome_frame_(false),
multi_install_(false) {
master_dictionary_.reset(ParseDistributionPreferences(prefs_path));
@@ -141,6 +144,8 @@ void MasterPreferences::InitializeFromCommandLine(const CommandLine& cmd_line) {
installer::master_preferences::kAutoLaunchChrome },
{ installer::switches::kChromeAppHost,
installer::master_preferences::kChromeAppHost },
+ { installer::switches::kChromeAppLauncher,
+ installer::master_preferences::kChromeAppLauncher },
{ installer::switches::kChrome,
installer::master_preferences::kChrome },
{ installer::switches::kChromeFrame,
@@ -210,6 +215,8 @@ void MasterPreferences::InitializeFromCommandLine(const CommandLine& cmd_line) {
}
void MasterPreferences::InitializeProductFlags() {
+ bool pref_chrome_app_host = false;
+ bool pref_chrome_app_launcher = false;
// Make sure we start out with the correct defaults.
multi_install_ = false;
chrome_frame_ = false;
@@ -218,7 +225,11 @@ void MasterPreferences::InitializeProductFlags() {
GetBool(installer::master_preferences::kMultiInstall, &multi_install_);
GetBool(installer::master_preferences::kChromeFrame, &chrome_frame_);
- GetBool(installer::master_preferences::kChromeAppHost, &chrome_app_host_);
+
+ GetBool(installer::master_preferences::kChromeAppHost, &pref_chrome_app_host);
+ GetBool(installer::master_preferences::kChromeAppLauncher,
+ &pref_chrome_app_launcher);
+ chrome_app_host_ = pref_chrome_app_host || pref_chrome_app_launcher;
// When multi-install is specified, the checks are pretty simple (in theory):
// In order to be installed/uninstalled, each product must have its switch

Powered by Google App Engine
This is Rietveld 408576698