Chromium Code Reviews| Index: chrome/installer/util/chrome_app_host_distribution.cc |
| diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc |
| index da20de6eea52160ba90b34098ae5ed3d09c03557..14265024a71c1dfdc8b2414277fbf9014e47fd5a 100644 |
| --- a/chrome/installer/util/chrome_app_host_distribution.cc |
| +++ b/chrome/installer/util/chrome_app_host_distribution.cc |
| @@ -48,6 +48,11 @@ string16 ChromeAppHostDistribution::GetAlternateApplicationName() { |
| return product_name; |
| } |
| +string16 ChromeAppHostDistribution::GetBaseAppId() { |
| + // See AppListController::GetAppModelId(). |
|
erikwright (departed)
2012/10/30 14:20:39
separate
huangs
2012/10/30 20:35:07
Done (adding TODO).
|
| + return L"ChromeAppList"; |
| +} |
| + |
| string16 ChromeAppHostDistribution::GetInstallSubDir() { |
| return BrowserDistribution::GetSpecificDistribution( |
| BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir(); |
| @@ -60,14 +65,10 @@ string16 ChromeAppHostDistribution::GetPublisherName() { |
| } |
| string16 ChromeAppHostDistribution::GetAppDescription() { |
| - NOTREACHED() << "This should never be accessed due to no start-menu/task-bar " |
| - << "shortcuts."; |
| return L"A standalone platform for Chrome apps."; |
|
erikwright (departed)
2012/10/30 14:20:39
Needs to be internationalized (moved to a resource
huangs
2012/10/30 20:35:07
Done.
|
| } |
| string16 ChromeAppHostDistribution::GetLongAppDescription() { |
| - NOTREACHED() << "This should never be accessed as Chrome App Host is not a " |
| - << "default browser option."; |
| return L"A standalone platform for Chrome apps."; |
|
erikwright (departed)
2012/10/30 14:20:39
Ditto.
huangs
2012/10/30 20:35:07
Done.
|
| } |
| @@ -102,14 +103,10 @@ std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const { |
| } |
| string16 ChromeAppHostDistribution::GetUninstallLinkName() { |
| - NOTREACHED() << "This should never be accessed as Chrome App Host has no " |
| - << "uninstall entry."; |
| return L"Uninstall Chrome App Host"; |
| } |
| string16 ChromeAppHostDistribution::GetUninstallRegPath() { |
| - NOTREACHED() << "This should never be accessed as Chrome App Host has no " |
| - << "uninstall entry."; |
| return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\" |
| L"Google Chrome App Host"; |
| } |
| @@ -126,7 +123,7 @@ bool ChromeAppHostDistribution::CanSetAsDefault() { |
| } |
| bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() { |
| - return false; |
| + return true; |
|
erikwright (departed)
2012/10/30 14:20:39
separate
huangs
2012/10/30 20:35:07
Done. (Added TODO).
|
| } |
| bool ChromeAppHostDistribution::GetCommandExecuteImplClsid( |