Implementing --app-launcher install/uninstall flow.

chrome/installer/setup/setup_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <msi.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
 #include "base/at_exit.h"
@@ skipping 343 matching lines @@
     const Product* binaries =
         installer_state->FindProduct(BrowserDistribution::CHROME_BINARIES);
     const Product* chrome_frame =
         installer_state->FindProduct(BrowserDistribution::CHROME_FRAME);
     const ProductState* cf_state =
         original_state.GetProductState(system_level,
                                        BrowserDistribution::CHROME_FRAME);
     const ProductState* chrome_state =
         original_state.GetProductState(system_level,
                                        BrowserDistribution::CHROME_BROWSER);
+    const ProductState* app_host_state =
+        original_state.GetProductState(system_level,
+                                       BrowserDistribution::CHROME_APP_HOST);
 
     if (!binaries) {
       // This will only be hit if --multi-install is given with no products, or
       // if the app host is being installed and doesn't need the binaries at
       // user-level.
       // The former case might be due to a request by an orphaned Application
       // Host to re-install the binaries. Thus we add them to the installation.
       // The latter case is fine and we let it be.
       // If this is not an app host install and the binaries are not already
       // present, the installation will fail later due to a lack of products to
@@ skipping 71 matching lines @@
     // Fail if we're installing Chrome Frame when a single-install of it is
     // already installed.
     if (chrome_frame && cf_state && !cf_state->is_multi_install()) {
       LOG(ERROR) << "Cannot migrate existing Chrome Frame installation to "
                  << "multi-install.";
       *status = installer::NON_MULTI_INSTALLATION_EXISTS;
       installer_state->WriteInstallerResult(*status,
           IDS_INSTALL_NON_MULTI_INSTALLATION_EXISTS_BASE, NULL);
       return false;
     }
+
+    if (app_host) {
+      // TODO(huangs): Revisit all these once App Launcher is default.
+      if (app_host_state) {
+        const installer::ChannelInfo& channel_info(app_host_state->channel());

[grt (UTC plus 2), 2012/10/25 14:46:53]

same here: don't use the channel info for this.  check uninstall_command() for
the switch you care about.

[huangs, 2012/10/29 21:15:16]

Done.

+        if (channel_info.IsAppLauncher() &&
+            !app_host->HasOption(installer::kOptionAppLauncher)) {
+          LOG(ERROR) << "Cannot downgrade from App Launcher to App Host";
+          *status = installer::HIGHER_VERSION_EXISTS;

[grt (UTC plus 2), 2012/10/25 14:46:53]

please introduce a new code rather than overloading an existing one.

[huangs, 2012/10/29 21:15:16]

Not doing this anymore, so moot.

+          return false;
+        }
+      }
+    }
+
   } else {
     // This is a non-multi installation.
 
     // Check for an existing installation of the product.
     const ProductState* product_state = original_state.GetProductState(
         system_level, products[0]->distribution()->GetType());
     if (product_state != NULL) {
       // Block downgrades from multi-install to single-install.
       if (product_state->is_multi_install()) {
         LOG(ERROR) << "Multi-install "
@@ skipping 959 matching lines @@
   prefs.GetBool(installer::master_preferences::kSystemLevel, &system_install);
   VLOG(1) << "system install is " << system_install;
 
   google_breakpad::scoped_ptr<google_breakpad::ExceptionHandler> breakpad(
       InitializeCrashReporting(system_install));
 
   InstallationState original_state;
   original_state.Initialize();
 
   InstallerState installer_state;
-  installer_state.Initialize(cmd_line, prefs, original_state);
+  if (!installer_state.Initialize(cmd_line, prefs, original_state)) {
+    LOG(ERROR) << "Conflicting options are found.";
+    // TODO(huangs): Find better error code!
+    return installer::INSTALL_FAILED;
+  }
   const bool is_uninstall = cmd_line.HasSwitch(installer::switches::kUninstall);
 
   // Check to make sure current system is WinXP or later. If not, log
   // error message and get out.
   if (!InstallUtil::IsOSSupported()) {
     LOG(ERROR) << "Chrome only supports Windows XP or later.";
     installer_state.WriteInstallerResult(
         installer::OS_NOT_SUPPORTED, IDS_INSTALL_OS_NOT_SUPPORTED_BASE, NULL);
     return installer::OS_NOT_SUPPORTED;
   }
@@ skipping 106 matching lines @@
   if (!(installer_state.is_msi() && is_uninstall))
     // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT
     // to pass through, since this is only returned on uninstall which is
     // never invoked directly by Google Update.
     return_code = InstallUtil::GetInstallReturnCode(install_status);
 
   VLOG(1) << "Installation complete, returning: " << return_code;
 
   return return_code;
 }