tools/testing/dart/test_progress.dart - Issue 11267008: Fix issue that cases the usesWebDriver getter in TestCase to always return false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11267008: Fix issue that cases the usesWebDriver getter in TestCase to always return false. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 13907a43267cddc693aadf9df24079fb58df8473..bcd027b362d4403f75918740c17961ef461514fb 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -131,7 +131,7 @@ class ProgressIndicator {

}

output.add(expected.toString());

output.add('Actual: ${test.output.result}');

- if (test.info != null) {

+ if (!test.output.hasTimedOut && test.info != null) {

if (test.output.incomplete && !test.info.hasCompileError) {

output.add('Unexpected compile-time error.');

} else {

« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')