PerformanceTests/Layout/AddWhitespace.html - Issue 1126673002: Test out performance when adding whitespace to the DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PerformanceTests/Layout/AddWhitespace.html

Issue 1126673002: Test out performance when adding whitespace to the DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

	5 <title>Adding whitespace performance test</title>

	6 <script src="../resources/runner.js"></script>

	7 </head>

	8 <body>

	9 <pre id="log"></pre>

	10 <div id="test">

	11 <div style="display: inline-block;"></div>
	leviw_travelin_and_unemployed 2015/05/04 20:55:24 Nit: your whitespace test has too much whitespace Nit: your whitespace test has too much whitespace ;)
	12 <div>
	leviw_travelin_and_unemployed 2015/05/04 20:55:24 </div>? </div>?
	13 <script>

	14 var target = document.getElementById("test");

	15 function test() {

	16 for (var i = 0; i < 100; i++) {

	17 target.innerHTML += ' <div style="display: inline-block;"></di v> ';
	esprehn 2015/05/04 21:22:40 This is serializing the DOM into a big string, des This is serializing the DOM into a big string, destroying all the existing nodes, recreating a whole new DOM with one extra div, then appending all those new nodes.
	18 PerfTestRunner.forceLayoutOrFullFrame();
	esprehn 2015/05/04 21:22:40 This is forcing a full frame update, that means co This is forcing a full frame update, that means compositing update and other stuff too. Since you're also destroying and recreating the entire page that's all you're really benchmarking.
	19 }

	20 target.innerHTML = '<div style="display: inline-block;"></div>';
	esprehn 2015/05/04 21:22:40 This is going to destroy all the nodes you created This is going to destroy all the nodes you created and recalced in the previous step.
	21 }

	22

	23 PerfTestRunner.measureRunsPerSecond({

	24 description: "Measures performance of layout when adding whitespace to a div.",
	leviw_travelin_and_unemployed 2015/05/04 20:55:24 This isn't the greatest description. Right now, yo This isn't the greatest description. Right now, you're measuring the performance of parsing and appending whitespace nodes and collapsed inlines. You may want to use DOM apis instead of innerHTML? What about testing pre-pending?
	25 run: test

	26 });

	27 </script>

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | PerformanceTests/Layout/AddWhitespaceToAnonymousTable.html » ('j') | PerformanceTests/Layout/AddWhitespaceToAnonymousTable.html » ('J')