Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1126663002: Use Mac assembly for x86 iOS simulator targets. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Mac assembly for x86 iOS simulator targets. BUG=484142 Committed: https://crrev.com/ec5b7687d06564998e7f1b96465878a391edc723 Cr-Commit-Position: refs/heads/master@{#328242}

Patch Set 1 #

Patch Set 2 : missed a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/boringssl/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
davidben
5 years, 7 months ago (2015-05-04 19:03:22 UTC) #2
kjellander_chromium
lgtm! I have confirmed that this solves the build problem we've seen for iOS x86 ...
5 years, 7 months ago (2015-05-04 20:33:01 UTC) #4
davidben
Is it still fine? I went to land this and realized I missed an else ...
5 years, 7 months ago (2015-05-04 21:01:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126663002/20001
5 years, 7 months ago (2015-05-04 23:54:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 00:59:06 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec5b7687d06564998e7f1b96465878a391edc723 Cr-Commit-Position: refs/heads/master@{#328242}
5 years, 7 months ago (2015-05-05 01:00:12 UTC) #10
kjellander_chromium
5 years, 7 months ago (2015-05-05 05:09:05 UTC) #11
Message was sent while issue was closed.
On 2015/05/04 21:01:28, David Benjamin wrote:
> Is it still fine? I went to land this and realized I missed an else block. (So
> this way you'll actually use the assembly and not just build it.)

Ah, great that you noticed. I just confirmed that compilation passed since we
don't have any tests for that platform configuration in WebRTC.

Powered by Google App Engine
This is Rietveld 408576698