Don't create a sync node when updating an URL that wasn't typed.

chrome/browser/sync/glue/typed_url_change_processor.cc

Index: chrome/browser/sync/glue/typed_url_change_processor.cc
diff --git a/chrome/browser/sync/glue/typed_url_change_processor.cc b/chrome/browser/sync/glue/typed_url_change_processor.cc
index 49f07fe102cdaaeed08adc1994c219294f4a4f06..044ac504a4dfd7087a42b6085bc1dbe88b78ea0a 100644
--- a/chrome/browser/sync/glue/typed_url_change_processor.cc
+++ b/chrome/browser/sync/glue/typed_url_change_processor.cc
@@ -157,6 +157,14 @@ bool TypedUrlChangeProcessor::CreateOrUpdateSyncNode(
     return false;
   }
 
+  if (std::find_if(visit_vector.begin(), visit_vector.end(),

[maniscalco, 2015/05/08 19:38:00]

Question about performance.  How big does visit_vector get and how often is
CreateOrUpdateSycnNode called?  If the vector is on the order of tens of items,
then I'm not worried.  Just want to make sure this isn't going to be super
expensive.

[mpawlowski, 2015/05/11 09:27:18]

Good point, I've checked with an old profile with loads of history and it seems
this can get big. I've just seen a 400+ sized vector for facebook.com.

I'm not sure what's the best way to approach this now. The only way to know if
an URL should be synced is by establishing whether it's been typed. There are
two tables in the history database that govern this: 'urls' and 'visits'. Each
entry in 'urls' has a 'typed_count' (which is used widely through typed history
sync code) but it's currently a broken heuristic - if I type "facebook.com" and
it gets redirected to "https://www.facebook.com", the second address has
'typed_count' = 0 even though the corresponding visit in the 'visits' table has
type PAGE_TRANSITION_TYPED. This is why I decided to inspect the visits database
instead of urls.

Maybe I should investigate fixing 'typed_count' in the 'urls' table so that it
is incremented for URLs that are results of server-side redirections to things
typed into the address bar. Or come up with a fast method of checking the
'visits' table within HistoryBackend that doesn't require iterating through that
much data (don't know if it's possible).

+                   [](const history::VisitRow& visit) {
+                     return ui::PageTransitionCoreTypeIs(
+                         visit.transition, ui::PAGE_TRANSITION_TYPED);
+                   }) == visit_vector.end())
+    // This URL has no TYPED visits, don't sync it.
+    return false;
+
   syncer::ReadNode typed_url_root(trans);
   if (typed_url_root.InitTypeRoot(syncer::TYPED_URLS) !=
           syncer::BaseNode::INIT_OK) {