Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/sync/test/integration/typed_urls_helper.h

Issue 1126633005: Don't create a sync node when updating an URL that wasn't typed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "components/history/core/browser/history_types.h" 10 #include "components/history/core/browser/history_types.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 history::VisitSource source, 54 history::VisitSource source,
55 const base::Time& timestamp); 55 const base::Time& timestamp);
56 56
57 // Deletes a URL from the history DB for a specific sync profile. 57 // Deletes a URL from the history DB for a specific sync profile.
58 void DeleteUrlFromHistory(int index, const GURL& url); 58 void DeleteUrlFromHistory(int index, const GURL& url);
59 59
60 // Deletes a list of URLs from the history DB for a specific sync 60 // Deletes a list of URLs from the history DB for a specific sync
61 // profile. 61 // profile.
62 void DeleteUrlsFromHistory(int index, const std::vector<GURL>& urls); 62 void DeleteUrlsFromHistory(int index, const std::vector<GURL>& urls);
63 63
64 // Modifies an URL stored in history by setting a new title.
65 void SetPageTitle(int index, const GURL& url, const std::string& title);
66
64 // Returns true if all clients match the verifier profile. 67 // Returns true if all clients match the verifier profile.
65 bool CheckAllProfilesHaveSameURLsAsVerifier(); 68 bool CheckAllProfilesHaveSameURLsAsVerifier();
66 69
67 // Returns true if all clients match the verifier profile and if the 70 // Returns true if all clients match the verifier profile and if the
68 // verification doesn't time out. 71 // verification doesn't time out.
69 bool AwaitCheckAllProfilesHaveSameURLsAsVerifier(); 72 bool AwaitCheckAllProfilesHaveSameURLsAsVerifier();
70 73
71 // Checks that the two vectors contain the same set of URLRows (possibly in 74 // Checks that the two vectors contain the same set of URLRows (possibly in
72 // a different order). 75 // a different order).
73 bool CheckURLRowVectorsAreEqual(const history::URLRows& left, 76 bool CheckURLRowVectorsAreEqual(const history::URLRows& left,
(...skipping 13 matching lines...) Expand all
87 // Returns a unique timestamp to use when generating page visits 90 // Returns a unique timestamp to use when generating page visits
88 // (HistoryService does not like having identical timestamps and will modify 91 // (HistoryService does not like having identical timestamps and will modify
89 // the timestamps behind the scenes if it encounters them, which leads to 92 // the timestamps behind the scenes if it encounters them, which leads to
90 // spurious test failures when the resulting timestamps aren't what we 93 // spurious test failures when the resulting timestamps aren't what we
91 // expect). 94 // expect).
92 base::Time GetTimestamp(); 95 base::Time GetTimestamp();
93 96
94 } // namespace typed_urls_helper 97 } // namespace typed_urls_helper
95 98
96 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_ 99 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_TYPED_URLS_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698