Test Keeping NaCl plugins used in app background pages alive when active.

extensions/browser/process_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_PROCESS_MANAGER_H_
 #define EXTENSIONS_BROWSER_PROCESS_MANAGER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 103 matching lines @@
   // onSuspendCanceled() event to it.
   void CancelSuspend(const Extension* extension);
 
   // Ensures background hosts are loaded for a new browser window.
   void OnBrowserWindowReady();
 
   // Gets the BrowserContext associated with site_instance_ and all other
   // related SiteInstances.
   content::BrowserContext* GetBrowserContext() const;
 
+  // Sets callbacks for testing keepalive impulse behavior.  When callbacks
+  // return true they must be released to free refcounted resources.

[yzshen1, 2014/01/03 22:10:10]

It seems there are two ways:
1) keep the void return value, and let the testing code call
ClearKeepaliveImpulseCallbackForTesting() (where it decides to return true in
the current patch).

2) If we would like to have the bool return value, I think the comment could be
revised to something like:
"If the callback returns true, this class clears the callback and it won't be
notified anymore."

I personally think (1) is more clear. What do you think?

[scheib, 2014/01/03 23:11:29]

I've changed to having the tests clear the callbacks.

+  typedef base::Callback<bool(const std::string& extension_id)>
+      ImpulseCallbackForTesting;
+  void SetKeepaliveImpulseCallbackForTesting(
+      const ImpulseCallbackForTesting& callback);
+  void SetKeepaliveImpulseDecrementCallbackForTesting(
+      const ImpulseCallbackForTesting& callback);
+
  protected:
   // If |context| is incognito pass the master context as |original_context|.
   // Otherwise pass the same context for both.
   ProcessManager(content::BrowserContext* context,
                  content::BrowserContext* original_context);
 
   // Called on browser shutdown to close our extension hosts.
   void CloseBackgroundHosts();
 
   // content::NotificationObserver:
@@ skipping 75 matching lines @@
 
   // The time to delay between sending a ShouldSuspend message and
   // sending a Suspend message; read from command-line switch.
   base::TimeDelta event_page_suspending_time_;
 
   // True if we have created the startup set of background hosts.
   bool startup_background_hosts_created_;
 
   base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_;
 
+  ImpulseCallbackForTesting keepalive_impulse_callback_for_testing_;
+  ImpulseCallbackForTesting keepalive_impulse_decrement_callback_for_testing_;
+
   base::WeakPtrFactory<ProcessManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessManager);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_PROCESS_MANAGER_H_