Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 1126613005: DM: add a Via to simulate SP pictures. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: add a Via to simulate SP pictures. Will use this to test the other CL that adds small SkPicture implementations. Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d31c13d0441aecc8b2a4fa4f45fd5e59584cb3ea

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : editorial #

Patch Set 4 : streamline #

Patch Set 5 : reorg a bit, add notes #

Patch Set 6 : int->scalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M dm/DM.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMSrcSink.h View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 4 5 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein
5 years, 7 months ago (2015-05-05 19:14:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126613005/60001
5 years, 7 months ago (2015-05-05 19:14:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/877)
5 years, 7 months ago (2015-05-05 19:20:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126613005/100001
5 years, 7 months ago (2015-05-05 19:29:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 19:39:23 UTC) #10
mtklein
lgtm
5 years, 7 months ago (2015-05-05 19:59:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126613005/100001
5 years, 7 months ago (2015-05-05 19:59:44 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 20:00:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d31c13d0441aecc8b2a4fa4f45fd5e59584cb3ea

Powered by Google App Engine
This is Rietveld 408576698