Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 11266056: Make --test-apk option mandatory. (Closed)

Created:
8 years, 1 month ago by frankf
Modified:
8 years, 1 month ago
Reviewers:
navabi1, bulach, newt (away)
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Make --test-apk option mandatory. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/pylib/test_options_parser.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
frankf
8 years, 1 month ago (2012-10-25 21:19:42 UTC) #1
newt (away)
LGTM. Though since --test-apk is a "required option", perhaps it should just be a positional ...
8 years, 1 month ago (2012-10-25 21:36:51 UTC) #2
frankf
Unfortunately, we use this pattern all over the place and is a shortcoming of optparse. ...
8 years, 1 month ago (2012-10-25 22:05:38 UTC) #3
newt (away)
On 2012/10/25 22:05:38, frankf wrote: > Unfortunately, we use this pattern all over the place ...
8 years, 1 month ago (2012-10-25 22:16:02 UTC) #4
bulach
8 years, 1 month ago (2012-10-26 09:39:17 UTC) #5
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698