Rename regexp methods to getters.

runtime/lib/string_base.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * [_StringBase] contains common methods used by concrete String
  * implementations, e.g., _OneByteString.
  */
 class _StringBase {
 
@@ skipping 186 matching lines @@
       throw new ArgumentError("${pattern} is not a Pattern");
     }
     if (replacement is! String) {
       throw new ArgumentError("${replacement} is not a String");
     }
     StringBuffer buffer = new StringBuffer();
     int startIndex = 0;
     Iterator iterator = pattern.allMatches(this).iterator();
     if (iterator.hasNext) {
       Match match = iterator.next();
-      buffer.add(this.substring(startIndex, match.start())).add(replacement);
-      startIndex = match.end();
+      buffer.add(this.substring(startIndex, match.start)).add(replacement);
+      startIndex = match.end;
     }
     return buffer.add(this.substring(startIndex)).toString();
   }
 
   String replaceAll(Pattern pattern, String replacement) {
     if (pattern is! Pattern) {
       throw new ArgumentError("${pattern} is not a Pattern");
     }
     if (replacement is! String) {
       throw new ArgumentError("${replacement} is not a String");
     }
     StringBuffer buffer = new StringBuffer();
     int startIndex = 0;
     for (Match match in pattern.allMatches(this)) {
-      buffer.add(this.substring(startIndex, match.start())).add(replacement);
-      startIndex = match.end();
+      buffer.add(this.substring(startIndex, match.start)).add(replacement);
+      startIndex = match.end;
     }
     return buffer.add(this.substring(startIndex)).toString();
   }
 
   /**
    * Convert all objects in [values] to strings and concat them
    * into a result string.
    */
   static String _interpolate(List values) {
     int numValues = values.length;
@@ skipping 36 matching lines @@
     }
     List<String> result = new List<String>();
     int startIndex = 0;
     int previousIndex = 0;
     while (true) {
       if (startIndex == length || !iterator.hasNext) {
         result.add(this.substring(previousIndex, length));
         break;
       }
       Match match = iterator.next();
-      if (match.start() == length) {
+      if (match.start == length) {
         result.add(this.substring(previousIndex, length));
         break;
       }
-      int endIndex = match.end();
+      int endIndex = match.end;
       if (startIndex == endIndex && endIndex == previousIndex) {
         ++startIndex;  // empty match, advance and restart
         continue;
       }
-      result.add(this.substring(previousIndex, match.start()));
+      result.add(this.substring(previousIndex, match.start));
       startIndex = previousIndex = endIndex;
     }
     return result;
   }
 
   List<String> splitChars() {
     int len = this.length;
     final result = new List<String>(len);
     for (int i = 0; i < len; i++) {
       result[i] = this[i];
@@ skipping 150 matching lines @@
   // whitespaces. Add checking for multi-byte whitespace codepoints.
   bool _isWhitespace(int codePoint) {
     return
       (codePoint === 32) || // Space.
       ((9 <= codePoint) && (codePoint <= 13)); // CR, LF, TAB, etc.
   }
 }
 
 
 class _StringMatch implements Match {
-  const _StringMatch(int this._start,
+  const _StringMatch(int this.start,
                      String this.str,
                      String this.pattern);
 
-  int start() => _start;
-  int end() => _start + pattern.length;
+  int get end => start + pattern.length;
   String operator[](int g) => group(g);
-  int groupCount() => 0;
+  int get groupCount => 0;
 
   String group(int group) {
     if (group != 0) {
       throw new IndexOutOfRangeException(group);
     }
     return pattern;
   }
 
   List<String> groups(List<int> groups) {
     List<String> result = new List<String>();
     for (int g in groups) {
       result.add(group(g));
     }
     return result;
   }
 
-  final int _start;
+  final int start;
   final String str;
   final String pattern;
 }