Rename regexp methods to getters.

pkg/intl/lib/bidi_utils.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Bidi stands for Bi-directional text.
  * According to http://en.wikipedia.org/wiki/Bi-directional_text:
  * Bi-directional text is text containing text in both text directionalities,
  * both right-to-left (RTL) and left-to-right (LTR). It generally involves text
  * containing different types of alphabets, but may also refer to boustrophedon,
@@ skipping 225 matching lines @@
    * the whole piece. If the tag already has a direction specified, this new one
    * will override existing one in behavior (tested on FF and IE).
    */
   static String _enforceInHtmlHelper(String html, String direction) {
     if (html.startsWith('<')) {
       StringBuffer buffer = new StringBuffer();
       var startIndex = 0;
       Match match = const RegExp('<\\w+').firstMatch(html);
       if (match != null) {
         buffer.add(html.substring(
-            startIndex, match.end())).add(' dir=$direction');
-        startIndex = match.end();
+            startIndex, match.end)).add(' dir=$direction');
+        startIndex = match.end;
       }
       return buffer.add(html.substring(startIndex)).toString();
     }
     // '\n' is important for FF so that it won't incorrectly merge span groups.
     return '\n<span dir=$direction>$html</span>';
   }
 
   /**
    * Apply bracket guard to [str] using html span tag. This is to address the
    * problem of messy bracket display that frequently happens in RTL layout.
@@ skipping 31 matching lines @@
    * would return 'firehydrant!'.
    */
   // TODO(efortuna): Get rid of this once this is implemented in Dart.
   // See Issue 2979.
   static String _guardBracketHelper(String str, RegExp regexp, [String before,
       String after]) {
     StringBuffer buffer = new StringBuffer();
     var startIndex = 0;
     Iterable matches = regexp.allMatches(str);
     for (Match match in matches) {
-      buffer.add(str.substring(startIndex, match.start())).add(before);
-      buffer.add(str.substring(match.start(), match.end())).add(after);
-      startIndex = match.end();
+      buffer.add(str.substring(startIndex, match.start)).add(before);
+      buffer.add(str.substring(match.start, match.end)).add(after);
+      startIndex = match.end;
     }
     return buffer.add(str.substring(startIndex)).toString();
   }
 
   /**
    * Estimates the directionality of [text] using the best known
    * general-purpose method (using relative word counts). A
    * TextDirection.UNKNOWN return value indicates completely neutral input.
    * [isHtml] is true if [text] HTML or HTML-escaped.
    *
@@ skipping 79 matching lines @@
 
   /**
    * Check the estimated directionality of [str], return true if the piece of
    * text should be laid out in RTL direction. If [isHtml] is true, the string
    * is HTML or HTML-escaped.
    */
   static bool detectRtlDirectionality(String str, {bool isHtml: false}) {
     return estimateDirectionOfText(str, isHtml: isHtml) == TextDirection.RTL;
   }
 }