Explicitly create a git config in the test repos.

utils/tests/pub/test_pub.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Test infrastructure for testing pub. Unlike typical unit tests, most pub
  * tests are integration tests that stage some stuff on the file system, run
  * pub, and then validate the results. This library provides an API to build
  * tests like that.
  */
@@ skipping 974 matching lines @@
  * Describes a Git repository and its contents.
  */
 class GitRepoDescriptor extends DirectoryDescriptor {
   GitRepoDescriptor(Pattern name, List<Descriptor> contents)
   : super(name, contents);
 
   /**
    * Creates the Git repository and commits the contents.
    */
   Future<Directory> create(parentDir) {
-    var workingDir;
-    Future runGit(List<String> args) => _runGit(args, workingDir);
-
-    return super.create(parentDir).chain((rootDir) {
-      workingDir = rootDir;
-      return runGit(['init']);
-    }).chain((_) => runGit(['add', '.']))
-      .chain((_) => runGit(['commit', '-m', 'initial commit',
-                            '--author="Pub Test <pub@dartlang.org>"']))
-      .transform((_) => workingDir);
+    return _runGitCommands(parentDir, [
+      ['init'],
+      ['add', '.'],
+      ['commit', '-m', 'initial commit']
+    ]);
   }
 
   /**
    * Commits any changes to the Git repository.
    */
   Future commit(parentDir) {
-    var workingDir;
-    Future runGit(List<String> args) => _runGit(args, workingDir);
-
-    return super.create(parentDir).chain((rootDir) {
-      workingDir = rootDir;
-      return runGit(['add', '.']);
-    }).chain((_) => runGit(['commit', '-m', 'update',
-                            '--author="Pub Test <pub@dartlang.org>"']));
+    return _runGitCommands(parentDir, [
+      ['add', '.'],
+      ['commit', '-m', 'update']
+    ]);
   }
 
   /**
    * Schedules changes to be committed to the Git repository.
    */
   void scheduleCommit() => _schedule((dir) => this.commit(dir));
 
   /**
    * Return a Future that completes to the commit in the git repository referred
    * to by [ref] at the current point in the scheduled test run.
    */
   Future<String> revParse(String ref) {
     var completer = new Completer<String>();
-    // TODO(nweiz): inline this once issue 3197 is fixed
-    var superCreate = super.create;
     _schedule((parentDir) {
-      return superCreate(parentDir).chain((rootDir) {
+      return super.create(parentDir).chain((rootDir) {
         return _runGit(['rev-parse', ref], rootDir);
       }).transform((output) {
         completer.complete(output[0]);
         return null;
       });
     });
     return completer.future;
   }
 
   /// Schedule a Git command to run in this repository.
   void scheduleGit(List<String> args) {
     _schedule((parentDir) {
       var gitDir = new Directory(join(parentDir, name));
       return _runGit(args, gitDir);
     });
   }
 
+  Future _runGitCommands(String parentDir, List<List<String>> commands) {
+    var workingDir;
+
+    Future runGitStep(_) {
+      if (commands.isEmpty) return new Future.immediate(workingDir);
+      var command = commands.removeAt(0);
+      return _runGit(command, workingDir).chain(runGitStep);
+    }
+
+    return super.create(parentDir).chain((rootDir) {
+      workingDir = rootDir;
+      return writeTextFile(join(parentDir, '.gitconfig'), '''
+[user]
+  name = Test Pub
+  email = pub@dartlang.org
+''');
+    }).chain(runGitStep);
+  }
+
   Future<String> _runGit(List<String> args, Directory workingDir) {
     return runGit(args, workingDir: workingDir.path).transform((result) {
       if (!result.success) {
         throw "Error running: git ${Strings.join(args, ' ')}\n"
             "${Strings.join(result.stderr, '\n')}";
       }
 
       return result.stdout;
     });
   }
@@ skipping 144 matching lines @@
 }
 
 /**
  * Schedules a callback to be called after Pub is run with [runPub], even if it
  * fails.
  */
 void _scheduleCleanup(_ScheduledEvent event) {
   if (_scheduledCleanup == null) _scheduledCleanup = [];
   _scheduledCleanup.add(event);
 }