Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/objects.cc

Issue 11266011: Delivery logic for Object.observe (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased against newest per-isolate patch Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/object-observe.js ('K') | « src/objects.h ('k') | src/runtime.h » ('j') | src/v8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 3ecbf22e4ded3636444716ddf76332023bc2e122..2c89319c72ead977a266b02194b1f353fdaaf88b 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1741,6 +1741,20 @@ void JSObject::EnqueueChangeRecord(
}
+void JSObject::DeliverChangeRecords(Isolate* isolate) {
+ ASSERT(isolate->has_active_object_observers());
+ isolate->set_has_active_object_observers(false);
rossberg 2012/11/06 16:45:57 This should probably be go to the end.
adamk 2012/11/06 17:00:09 Done.
+ bool threw = false;
+ Execution::Call(
+ isolate->observers_deliver_changes(),
+ isolate->factory()->undefined_value(),
+ 0,
+ NULL,
+ &threw);
+ ASSERT(!threw);
+}
+
+
MaybeObject* JSObject::SetPropertyPostInterceptor(
String* name,
Object* value,
« src/object-observe.js ('K') | « src/objects.h ('k') | src/runtime.h » ('j') | src/v8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698