Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1126553002: Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in net/socket/ module. (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in net/socket/ module. MessageLoopProxy is deprecated. This basically does search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/30444467d4d5d3e7e1489df1d5c2febfe307e0d4 Cr-Commit-Position: refs/heads/master@{#328248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-04 11:14:46 UTC) #2
eroman
lgtm
5 years, 7 months ago (2015-05-04 21:49:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126553002/1
5 years, 7 months ago (2015-05-05 00:59:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 01:35:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 01:36:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30444467d4d5d3e7e1489df1d5c2febfe307e0d4
Cr-Commit-Position: refs/heads/master@{#328248}

Powered by Google App Engine
This is Rietveld 408576698