Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1126543010: Set correct class name for interfaces with disabled partials (Closed)

Created:
5 years, 7 months ago by Jens Widell
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set correct class name for interfaces with disabled partials If an runtime enabled interface was disabled, we'd initialize its v8::FunctionTemplate's class name to the empty string. We'd also do this if a runtime enabled *partial* interface was disabled, even though the interface as a whole was enabled, which is clearly wrong. As a simple fix, simply always set the interface's real name. If the interface is disabled, it won't matter what it's set to anyway. BUG=475830 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL A slightly more proper fix might be to split V8DOMConfiguration::installDOMClassTemplate() into two; one part ...
5 years, 7 months ago (2015-05-05 14:42:38 UTC) #2
haraken
LGTM > A slightly more proper fix might be to split > V8DOMConfiguration::installDOMClassTemplate() into two; ...
5 years, 7 months ago (2015-05-05 16:02:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126543010/1
5 years, 7 months ago (2015-05-05 16:45:20 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 20:07:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194937

Powered by Google App Engine
This is Rietveld 408576698