Chromium Code Reviews| Index: build/android/pylib/gtest/gtest_test_instance.py |
| diff --git a/build/android/pylib/gtest/gtest_test_instance.py b/build/android/pylib/gtest/gtest_test_instance.py |
| index b6f83b31b2e97637c55036da84b6c9b28f6f5d28..403ed58723537a638d82e09857f22a10ac74b0ea 100644 |
| --- a/build/android/pylib/gtest/gtest_test_instance.py |
| +++ b/build/android/pylib/gtest/gtest_test_instance.py |
| @@ -17,6 +17,22 @@ sys.path.append(os.path.join( |
| import unittest_util |
| +BROWSER_TEST_FLAGS = [ |
| + # content::kSingleProcessTestsFlag |
| + '--single_process', |
|
Ted C
2015/05/05 23:11:17
Any reason we don't add these in the java side act
jbudorick
2015/05/06 18:00:00
Nope, and it's cleaner to do so.
|
| + |
| + # switches::kUseFakeDeviceForMediaStream |
| + '--use-fake-device-for-media-stream', |
| + |
| + # switches::kUseFakeUIForMediaStream, |
| + '--use-fake-ui-for-media-stream', |
| +] |
| +BROWSER_TEST_SUITES = [ |
| + 'components_browsertests', |
| + 'content_browsertests', |
| +] |
| + |
| + |
| # Used for filtering large data deps at a finer grain than what's allowed in |
| # isolate files since pushing deps to devices is expensive. |
| # Wildcards are allowed. |
| @@ -92,16 +108,14 @@ class GtestTestInstance(test_instance.TestInstance): |
| raise ValueError('Platform mode currently supports only 1 gtest suite') |
| self._suite = args.suite_name[0] |
| - if (self._suite == 'content_browsertests' or |
| - self._suite == 'components_browsertests'): |
| - error_func('%s are not currently supported ' |
| - 'in platform mode.' % self._suite) |
| - self._apk_path = os.path.join( |
| - constants.GetOutDirectory(), 'apks', '%s.apk' % self._suite) |
| + if self._suite in BROWSER_TEST_SUITES: |
| + self._flags = BROWSER_TEST_FLAGS |
| else: |
| - self._apk_path = os.path.join( |
| - constants.GetOutDirectory(), '%s_apk' % self._suite, |
| - '%s-debug.apk' % self._suite) |
| + self._flags = [] |
| + |
| + self._apk_path = os.path.join( |
| + constants.GetOutDirectory(), '%s_apk' % self._suite, |
| + '%s-debug.apk' % self._suite) |
| self._exe_path = os.path.join(constants.GetOutDirectory(), |
| self._suite) |
| if not os.path.exists(self._apk_path): |
| @@ -237,6 +251,10 @@ class GtestTestInstance(test_instance.TestInstance): |
| return self._exe_path |
| @property |
| + def flags(self): |
| + return self._flags |
| + |
| + @property |
| def suite(self): |
| return self._suite |