Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1126543003: Adding missing profile.h include to extensions code. (Closed)

Created:
5 years, 7 months ago by Daniel Bratell
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing profile.h include to extensions code. external_pref_loader.cc uses profile.h so it needs to include it and not rely on some other random code to include it. Fixes compilation problems in certain configurations. Committed: https://crrev.com/9c086426f0e4f8f77706ea02abb927419c51d907 Cr-Commit-Position: refs/heads/master@{#328511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/external_pref_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniel Bratell
Just a missing include, please take a look.
5 years, 7 months ago (2015-05-04 14:44:14 UTC) #2
asargent_no_longer_on_chrome
lgtm
5 years, 7 months ago (2015-05-05 20:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126543003/1
5 years, 7 months ago (2015-05-06 07:43:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 09:30:43 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 09:31:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c086426f0e4f8f77706ea02abb927419c51d907
Cr-Commit-Position: refs/heads/master@{#328511}

Powered by Google App Engine
This is Rietveld 408576698