Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Side by Side Diff: mojo/public/tools/bindings/mojom.gni

Issue 1126533003: Remove unused target_visibility assignment from mojom gni (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../../mojo_sdk.gni") 5 import("../../mojo_sdk.gni")
6 6
7 # Generate C++/JavaScript/Java/Python/Dart/Go source files from mojom files. The 7 # Generate C++/JavaScript/Java/Python/Dart/Go source files from mojom files. The
8 # output files will go under the generated file directory tree with the same 8 # output files will go under the generated file directory tree with the same
9 # path as each input file. 9 # path as each input file.
10 # 10 #
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 rebased_mojo_sdk_deps = [] 157 rebased_mojo_sdk_deps = []
158 if (defined(invoker.mojo_sdk_deps)) { 158 if (defined(invoker.mojo_sdk_deps)) {
159 foreach(sdk_dep, invoker.mojo_sdk_deps) { 159 foreach(sdk_dep, invoker.mojo_sdk_deps) {
160 # Check that the SDK dep was not mistakenly given as an absolute path. 160 # Check that the SDK dep was not mistakenly given as an absolute path.
161 assert(get_path_info(sdk_dep, "abspath") != sdk_dep) 161 assert(get_path_info(sdk_dep, "abspath") != sdk_dep)
162 rebased_mojo_sdk_deps += [ rebase_path(sdk_dep, ".", mojo_root) ] 162 rebased_mojo_sdk_deps += [ rebase_path(sdk_dep, ".", mojo_root) ]
163 } 163 }
164 } 164 }
165 165
166 if (defined(invoker.visibility)) {
167 # Need to save this because the the target_name is overwritten inside the
168 # action to be that of the action itself. Only define this in the case the
169 # var is used to avoid unused var error.
170 target_visibility = [ ":$target_name" ]
171 }
172
173 if (defined(invoker.sources)) { 166 if (defined(invoker.sources)) {
174 generator_target_name = target_name + "__generator" 167 generator_target_name = target_name + "__generator"
175 action_foreach(generator_target_name) { 168 action_foreach(generator_target_name) {
176 script = generator_script 169 script = generator_script
177 inputs = generator_sources 170 inputs = generator_sources
178 sources = invoker.sources 171 sources = invoker.sources
179 outputs = generator_cpp_outputs + generator_dart_outputs + 172 outputs = generator_cpp_outputs + generator_dart_outputs +
180 generator_go_outputs + generator_java_outputs + 173 generator_go_outputs + generator_java_outputs +
181 generator_js_outputs + generator_python_outputs 174 generator_js_outputs + generator_python_outputs
182 args = [ 175 args = [
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 # //mojo/something:something and we can append "_java" to get the java 407 # //mojo/something:something and we can append "_java" to get the java
415 # dependency name. 408 # dependency name.
416 full_name = get_label_info(d, "label_no_toolchain") 409 full_name = get_label_info(d, "label_no_toolchain")
417 deps += [ "${full_name}_java" ] 410 deps += [ "${full_name}_java" ]
418 } 411 }
419 412
420 srcjar_deps = [ ":$java_srcjar_target_name" ] 413 srcjar_deps = [ ":$java_srcjar_target_name" ]
421 } 414 }
422 } 415 }
423 } 416 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698