Source/core/page/EventSource.h - Issue 112653006: Make calls to AtomicString(const String&) explicit in page/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventSource.h

Issue 112653006: Make calls to AtomicString(const String&) explicit in page/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventSource.h

diff --git a/Source/core/page/EventSource.h b/Source/core/page/EventSource.h

index 66ea83aa1b88dbef0d998ab228ef4bcb10822057..bb669b524488784db34d99214c9a41ad76f9ce49 100644

--- a/Source/core/page/EventSource.h

+++ b/Source/core/page/EventSource.h

@@ -117,10 +117,10 @@ private:

bool m_discardTrailingNewline;

bool m_requestInFlight;

- String m_eventName;

+ AtomicString m_eventName;

Vector<UChar> m_data;

- String m_currentlyParsedEventId;

- String m_lastEventId;

+ AtomicString m_currentlyParsedEventId;

+ AtomicString m_lastEventId;

unsigned long long m_reconnectDelay;

String m_eventStreamOrigin;

};

« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »