Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/page/EventHandler.cpp

Issue 112653006: Make calls to AtomicString(const String&) explicit in page/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | Source/core/page/EventSource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 3178 matching lines...) Expand 10 before | Expand all | Expand 10 after
3189 m_frame->editor().handleKeyboardEvent(event); 3189 m_frame->editor().handleKeyboardEvent(event);
3190 if (event->defaultHandled()) 3190 if (event->defaultHandled())
3191 return; 3191 return;
3192 if (event->keyIdentifier() == "U+0009") 3192 if (event->keyIdentifier() == "U+0009")
3193 defaultTabEventHandler(event); 3193 defaultTabEventHandler(event);
3194 else if (event->keyIdentifier() == "U+0008") 3194 else if (event->keyIdentifier() == "U+0008")
3195 defaultBackspaceEventHandler(event); 3195 defaultBackspaceEventHandler(event);
3196 else if (event->keyIdentifier() == "U+001B") 3196 else if (event->keyIdentifier() == "U+001B")
3197 defaultEscapeEventHandler(event); 3197 defaultEscapeEventHandler(event);
3198 else { 3198 else {
3199 FocusDirection direction = focusDirectionForKey(event->keyIdentifier ()); 3199 FocusDirection direction = focusDirectionForKey(AtomicString(event-> keyIdentifier()));
3200 if (direction != FocusDirectionNone) 3200 if (direction != FocusDirectionNone)
3201 defaultArrowEventHandler(direction, event); 3201 defaultArrowEventHandler(direction, event);
3202 } 3202 }
3203 } 3203 }
3204 if (event->type() == EventTypeNames::keypress) { 3204 if (event->type() == EventTypeNames::keypress) {
3205 m_frame->editor().handleKeyboardEvent(event); 3205 m_frame->editor().handleKeyboardEvent(event);
3206 if (event->defaultHandled()) 3206 if (event->defaultHandled())
3207 return; 3207 return;
3208 if (event->charCode() == ' ') 3208 if (event->charCode() == ' ')
3209 defaultSpaceEventHandler(event); 3209 defaultSpaceEventHandler(event);
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
4033 unsigned EventHandler::accessKeyModifiers() 4033 unsigned EventHandler::accessKeyModifiers()
4034 { 4034 {
4035 #if OS(MACOSX) 4035 #if OS(MACOSX)
4036 return PlatformEvent::CtrlKey | PlatformEvent::AltKey; 4036 return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
4037 #else 4037 #else
4038 return PlatformEvent::AltKey; 4038 return PlatformEvent::AltKey;
4039 #endif 4039 #endif
4040 } 4040 }
4041 4041
4042 } // namespace WebCore 4042 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/page/DragController.cpp ('k') | Source/core/page/EventSource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698