Cleanup ColorDistance

Cleanup ColorDistance

Remove all constructors, remove clampColor as we can just use makeRGBA.
Also make distance static so we don't need any state in this helper class.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164409

[rwlbuis, 2013-12-31 21:41:33]

An idea to clean this file up a bit. Obviously it reduces binary size as some
methods are removed. I am also wondering if this could move into an existing
class so this file can be removed.

[eseidel, 2013-12-31 21:59:58]

https://codereview.chromium.org/112653005/diff/1/Source/core/svg/SVGAnimatedC...
File Source/core/svg/SVGAnimatedColor.cpp (right):

https://codereview.chromium.org/112653005/diff/1/Source/core/svg/SVGAnimatedC...
Source/core/svg/SVGAnimatedColor.cpp:97: animatedColor =
makeRGBA(static_cast<int>(roundf(animatedRed)),
static_cast<int>(roundf(animatedGreen)), static_cast<int>(roundf(animatedBlue)),
static_cast<int>(roundf(animatedAlpha)));
What about the clamping?

[rwlbuis, 2013-12-31 22:03:41]

On 2013/12/31 21:59:58, eseidel wrote:
>
https://codereview.chromium.org/112653005/diff/1/Source/core/svg/SVGAnimatedC...
> File Source/core/svg/SVGAnimatedColor.cpp (right):
> 
>
https://codereview.chromium.org/112653005/diff/1/Source/core/svg/SVGAnimatedC...
> Source/core/svg/SVGAnimatedColor.cpp:97: animatedColor =
> makeRGBA(static_cast<int>(roundf(animatedRed)),
> static_cast<int>(roundf(animatedGreen)),
static_cast<int>(roundf(animatedBlue)),
> static_cast<int>(roundf(animatedAlpha)));
> What about the clamping?

makeRGBA clamps all channels to 0,255 range, like the old code in ColorDistance
did.

[eseidel, 2013-12-31 23:10:57]

lgtm

[commit-bot: I haz the power, 2013-12-31 23:11:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/112653005/1

[commit-bot: I haz the power, 2014-01-01 00:44:38]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2014-01-01 11:49:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/112653005/1

[commit-bot: I haz the power, 2014-01-01 12:35:36]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2014-01-01 15:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/112653005/1

[commit-bot: I haz the power, 2014-01-01 15:34:47]

Change committed as 164409