net/data/proxy_resolver_v8_tracing_unittest/error_on_load.js - Issue 1126513002: Add ProxyResolverFactoryV8Tracing. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1234)

My Issues | Starred Open | Closed | All

Side by Side Diff: net/data/proxy_resolver_v8_tracing_unittest/error_on_load.js

Issue 1126513002: Add ProxyResolverFactoryV8Tracing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-proxy-refactor

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | net/proxy/mojo_proxy_resolver_factory_impl.cc » ('j') | net/proxy/proxy_resolver_v8_tracing.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 alert('Prepare to DIE!');
	eroman 2015/05/05 00:04:55 Note: You may hit some presubmit warning about lac Note: You may hit some presubmit warning about lack of copyright (we have something baked in that enforces it on all .js). If you need to add a copyright line don't worry about getting another review pass for it. Sam McNally* 2015/05/05 01:31:36 Done. The presubmit's already unhappy about the ex Show quoted text On 2015/05/05 00:04:55, eroman wrote: > Note: You may hit some presubmit warning about lack of copyright (we have > something baked in that enforces it on all *.js). If you need to add a copyright > line don't worry about getting another review pass for it. Done. The presubmit's already unhappy about the extra ScopedAllowIO.
	2 var x = null;

	3 return x.split('-'); // Throws exception.

	4

	5 function FindProxyForURL(url, host) {

	6 return "PROXY i-approve-this-message:42";

	7 }

OLD	NEW

« no previous file with comments | « no previous file | net/proxy/mojo_proxy_resolver_factory_impl.cc » ('j') | net/proxy/proxy_resolver_v8_tracing.h » ('J')

Powered by Google App Engine

This is Rietveld 408576698