Issue 11265046: cc: Add some impl-side painting stub classes and APIs

Issue 11265046: cc: Add some impl-side painting stub classes and APIs (Closed)

Created:
8 years, 1 month ago by enne (OOO)

Modified:
8 years, 1 month ago

Reviewers:
jamesr, nduca

CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Add some impl-side painting stub classes and APIs BUG=155209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166615

Patch Set 2 : Address nduca bikesheddery #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -22 lines)			Patch
M	cc/cc.gyp	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	cc/picture.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A +	cc/picture.cc	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
A	cc/picture_layer.h	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
A	cc/picture_layer.cc	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	cc/picture_layer_impl.h	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
A +	cc/picture_layer_impl.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
A	cc/picture_pile.h	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
A	cc/picture_pile.cc	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	webkit/compositor_bindings/web_content_layer_impl.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/compositor_bindings/web_content_layer_impl.cc	View		2 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

Using this switch doesn't work yet, but I wanted to land some base classes first ...

8 years, 1 month ago (2012-11-08 00:47:38 UTC) #1

nduca

Omnomonm lgtm https://codereview.chromium.org/11265046/diff/1/cc/picture.h File cc/picture.h (right): https://codereview.chromium.org/11265046/diff/1/cc/picture.h#newcode35 cc/picture.h:35: // Clone a paint-safe version of this ...

8 years, 1 month ago (2012-11-08 00:49:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11265046/4001

8 years, 1 month ago (2012-11-08 00:57:01 UTC) #3

Change committed as 166615

Expand Messages | Collapse Messages