Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Unified Diff: chrome/browser/ui/android/external_protocol_dialog_android.cc

Issue 11265013: [Android] Use resource throttle instead of HandleExternalProtocol. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/external_protocol_dialog_android.cc
diff --git a/chrome/browser/ui/android/external_protocol_dialog_android.cc b/chrome/browser/ui/android/external_protocol_dialog_android.cc
index a39764e22f1bf8c6729efe8519fdb229cdfef24f..dc9bb6b59c2fa251245db98595abf4411a9d0bd8 100644
--- a/chrome/browser/ui/android/external_protocol_dialog_android.cc
+++ b/chrome/browser/ui/android/external_protocol_dialog_android.cc
@@ -13,11 +13,8 @@ using content::WebContents;
// static
void ExternalProtocolHandler::RunExternalProtocolDialog(
const GURL& url, int render_process_host_id, int routing_id) {
- WebContents* web_contents = tab_util::GetWebContentsByID(
- render_process_host_id, routing_id);
- if (web_contents) {
- TabAndroid* tab = TabAndroid::FromWebContents(web_contents);
- if (tab)
- return tab->RunExternalProtocolDialog(url);
- }
+ // Chrome on Android uses a throttle-based mechansim to intercept links
+ // so that the user may choose to run an Android application instead of
+ // loading the link in the browser. This mechanism also handles external
+ // protocols, so we don't need to do anything here.
mkosiba (inactive) 2012/10/25 09:02:12 NOTREACHED?
John Knottenbelt 2012/10/25 16:17:27 Done.
}

Powered by Google App Engine
This is Rietveld 408576698