[Android] Use resource throttle instead of HandleExternalProtocol.

content/browser/renderer_host/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/renderer_host/resource_dispatcher_host_impl.h"
 
 #include <set>
 #include <vector>
@@ skipping 641 matching lines @@
   if (delegate_ && !delegate_->AcceptSSLClientCertificateRequest(
           loader->request(), cert_info)) {
     return false;
   }
 
   return true;
 }
 
 bool ResourceDispatcherHostImpl::HandleExternalProtocol(ResourceLoader* loader,
                                                         const GURL& url) {
+#if defined OS(ANDROID)
+  return false;

[joth, 2012/10/24 18:47:55]

Did you mean this? you've changed delegate_->HandleExternalProtocol to return
bool instead -- shouldn't we just be returning that result below, no need for
ifdef here?

[mkosiba (inactive), 2012/10/25 09:02:12]

Do what Joth says ;)

[John Knottenbelt, 2012/10/25 16:17:27]

Yes, I agree. Sorry, this was accidentally left in from an experiment. 

On 2012/10/24 18:47:55, joth wrote:
ad -- shouldn't we just be returning that result below, no need for

+#endif
+
   if (!delegate_)
     return false;
 
   ResourceRequestInfoImpl* info = loader->GetRequestInfo();
 
   if (!ResourceType::IsFrame(info->GetResourceType()))
     return false;
 
   const net::URLRequestJobFactory* job_factory =
       info->GetContext()->GetRequestContext()->job_factory();
   if (job_factory->IsHandledURL(url))
     return false;
 
   delegate_->HandleExternalProtocol(url, info->GetChildID(),
                                     info->GetRouteID());
+
   return true;
 }
 
 void ResourceDispatcherHostImpl::DidStartRequest(ResourceLoader* loader) {
   // Make sure we have the load state monitor running
   if (!update_load_states_timer_->IsRunning()) {
     update_load_states_timer_->Start(FROM_HERE,
         TimeDelta::FromMilliseconds(kUpdateLoadStatesIntervalMsec),
         this, &ResourceDispatcherHostImpl::UpdateLoadStates);
   }
@@ skipping 1035 matching lines @@
 
   return i->second.get();
 }
 
 ResourceLoader* ResourceDispatcherHostImpl::GetLoader(int child_id,
                                                       int request_id) const {
   return GetLoader(GlobalRequestID(child_id, request_id));
 }
 
 }  // namespace content