Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 1126453002: Adding strict mode for bookmark_manager file for better error checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(arv): Now that this is driven by a data model, implement a data model 5 // TODO(arv): Now that this is driven by a data model, implement a data model
6 // that handles the loading and the events from the bookmark backend. 6 // that handles the loading and the events from the bookmark backend.
7 7
8 /** 8 /**
9 * @typedef {{childIds: Array<string>}} 9 * @typedef {{childIds: Array<string>}}
10 * 10 *
11 * @see chrome/common/extensions/api/bookmarks.json 11 * @see chrome/common/extensions/api/bookmarks.json
12 */ 12 */
13 var ReorderInfo; 13 var ReorderInfo;
14 14
15 /** 15 /**
16 * @typedef {{parentId: string, 16 * @typedef {{parentId: string,
17 * index: number, 17 * index: number,
18 * oldParentId: string, 18 * oldParentId: string,
19 * oldIndex: number}} 19 * oldIndex: number}}
20 * 20 *
21 * @see chrome/common/extensions/api/bookmarks.json 21 * @see chrome/common/extensions/api/bookmarks.json
22 */ 22 */
23 var MoveInfo; 23 var MoveInfo;
24 24
25 cr.define('bmm', function() { 25 cr.define('bmm', function() {
26 'use strict';
27
26 var List = cr.ui.List; 28 var List = cr.ui.List;
27 var ListItem = cr.ui.ListItem; 29 var ListItem = cr.ui.ListItem;
28 var ArrayDataModel = cr.ui.ArrayDataModel; 30 var ArrayDataModel = cr.ui.ArrayDataModel;
29 var ContextMenuButton = cr.ui.ContextMenuButton; 31 var ContextMenuButton = cr.ui.ContextMenuButton;
30 32
31 /** 33 /**
32 * Basic array data model for use with bookmarks. 34 * Basic array data model for use with bookmarks.
33 * @param {!Array<!BookmarkTreeNode>} items The bookmark items. 35 * @param {!Array<!BookmarkTreeNode>} items The bookmark items.
34 * @constructor 36 * @constructor
35 * @extends {ArrayDataModel} 37 * @extends {ArrayDataModel}
(...skipping 590 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 } 628 }
627 } 629 }
628 } 630 }
629 }; 631 };
630 632
631 return { 633 return {
632 BookmarkList: BookmarkList, 634 BookmarkList: BookmarkList,
633 list: /** @type {Element} */(null), // Set when decorated. 635 list: /** @type {Element} */(null), // Set when decorated.
634 }; 636 };
635 }); 637 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/bmm.js ('k') | chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698