Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/resources/bookmark_manager/js/bmm.js

Issue 1126453002: Adding strict mode for bookmark_manager file for better error checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('bmm', function() { 5 cr.define('bmm', function() {
6 'use strict';
7
6 /** 8 /**
7 * Whether a node contains another node. 9 * Whether a node contains another node.
8 * TODO(yosin): Once JavaScript style guide is updated and linter follows 10 * TODO(yosin): Once JavaScript style guide is updated and linter follows
9 * that, we'll remove useless documentations for |parent| and |descendant|. 11 * that, we'll remove useless documentations for |parent| and |descendant|.
10 * TODO(yosin): bmm.contains() should be method of BookmarkTreeNode. 12 * TODO(yosin): bmm.contains() should be method of BookmarkTreeNode.
11 * @param {!BookmarkTreeNode} parent . 13 * @param {!BookmarkTreeNode} parent .
12 * @param {!BookmarkTreeNode} descendant . 14 * @param {!BookmarkTreeNode} descendant .
13 * @return {boolean} Whether the parent contains the descendant. 15 * @return {boolean} Whether the parent contains the descendant.
14 */ 16 */
15 function contains(parent, descendant) { 17 function contains(parent, descendant) {
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 }; 252 };
251 253
252 return { 254 return {
253 contains: contains, 255 contains: contains,
254 isFolder: isFolder, 256 isFolder: isFolder,
255 loadSubtree: loadSubtree, 257 loadSubtree: loadSubtree,
256 loadTree: loadTree, 258 loadTree: loadTree,
257 addBookmarkModelListeners: addBookmarkModelListeners 259 addBookmarkModelListeners: addBookmarkModelListeners
258 }; 260 };
259 }); 261 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698