Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1126453002: Adding strict mode for bookmark_manager file for better error checking. (Closed)

Created:
5 years, 7 months ago by Deepak
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding strict mode for bookmark_manager file for better error checking. Adding strict mode to bookmark manager's js files to detect error at load time itself. Test = None. BUG=483186 Committed: https://crrev.com/fd99cc3a93098cb150412c17096cef9e53c94629 Cr-Commit-Position: refs/heads/master@{#328280}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Deepak
This is relanding of https://codereview.chromium.org/1115683002/ after resolving closureCompilation error and verifying by GYP_GENERATORS=ninja tools/gyp/gyp --depth ...
5 years, 7 months ago (2015-05-02 06:22:07 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1126453002/diff/1/chrome/browser/resources/bookmark_manager/js/main.js File chrome/browser/resources/bookmark_manager/js/main.js (right): https://codereview.chromium.org/1126453002/diff/1/chrome/browser/resources/bookmark_manager/js/main.js#newcode6 chrome/browser/resources/bookmark_manager/js/main.js:6: 'use strict'; nit: same indent as... the rest ...
5 years, 7 months ago (2015-05-04 16:39:26 UTC) #3
Deepak
On 2015/05/04 16:39:26, Dan Beam wrote: > lgtm > > https://codereview.chromium.org/1126453002/diff/1/chrome/browser/resources/bookmark_manager/js/main.js > File chrome/browser/resources/bookmark_manager/js/main.js (right): ...
5 years, 7 months ago (2015-05-05 03:53:11 UTC) #4
Deepak
nit Addressed. Thanks https://codereview.chromium.org/1126453002/diff/1/chrome/browser/resources/bookmark_manager/js/main.js File chrome/browser/resources/bookmark_manager/js/main.js (right): https://codereview.chromium.org/1126453002/diff/1/chrome/browser/resources/bookmark_manager/js/main.js#newcode6 chrome/browser/resources/bookmark_manager/js/main.js:6: 'use strict'; On 2015/05/04 16:39:26, Dan ...
5 years, 7 months ago (2015-05-05 03:53:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126453002/20001
5 years, 7 months ago (2015-05-05 03:54:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 05:09:29 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 05:10:33 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fd99cc3a93098cb150412c17096cef9e53c94629
Cr-Commit-Position: refs/heads/master@{#328280}

Powered by Google App Engine
This is Rietveld 408576698