Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 1126443002: Move user_story.user_story_set to story.story_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update init file. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index bc7a57398772417ac73982bb62f88e7b75025a51..3463a109f1e2d2b54e91fb8f19b8c6ad53990945 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -58,7 +58,7 @@ class Benchmark(command_line.Command):
Benchmarks default to using TBM unless you override the value of
Benchmark.test, or override the CreatePageTest method.
- New benchmarks should override CreateUserStorySet.
+ New benchmarks should override CreateStorySet.
"""
options = {}
test = timeline_based_measurement.TimelineBasedMeasurement
@@ -184,11 +184,11 @@ class Benchmark(command_line.Command):
pt._enabled_strings = self._enabled_strings
expectations = self.CreateExpectations()
- us = self.CreateUserStorySet(finder_options)
+ us = self.CreateStorySet(finder_options)
if isinstance(pt, page_test.PageTest):
if any(not isinstance(p, page.Page) for p in us.user_stories):
raise Exception(
- 'PageTest must be used with UserStorySet containing only '
+ 'PageTest must be used with StorySet containing only '
'telemetry.page.Page user stories.')
self._DownloadGeneratedProfileArchive(finder_options)
@@ -327,7 +327,7 @@ class Benchmark(command_line.Command):
raise TypeError('"%s" is not a PageSet.' % self.page_set.__name__)
return self.page_set()
- def CreateUserStorySet(self, options):
+ def CreateStorySet(self, options):
return self.CreatePageSet(options)
@classmethod

Powered by Google App Engine
This is Rietveld 408576698