Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1126423005: quickie tool to exercise chrome filter fuzz files (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

quickie tool to exercise chrome filter fuzz files This is a quick Skia transcription of the Chromium tool at src/skia/tools/filter_fuzz_stub.cc to read and decode filters captured as .fil files. R=joshualitt@google.com,mtklein@google.com,reed@google.com,robertphillips@google.com BUG=487213 Committed: https://skia.googlesource.com/skia/+/7da2e55ccbad4868a455c1c9f23e5f63bd99e916

Patch Set 1 #

Patch Set 2 : forgot to add the source file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M gyp/tools.gyp View 2 chunks +11 lines, -0 lines 0 comments Download
A tools/chrome_fuzz.cpp View 1 1 chunk +82 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126423005/20001
5 years, 7 months ago (2015-05-12 15:30:24 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-12 15:30:26 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1126423005/diff/20001/tools/chrome_fuzz.cpp File tools/chrome_fuzz.cpp (right): https://codereview.chromium.org/1126423005/diff/20001/tools/chrome_fuzz.cpp#newcode1 tools/chrome_fuzz.cpp:1: // Copyright 2013 The Chromium Authors. All rights ...
5 years, 7 months ago (2015-05-12 15:34:17 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:36:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7da2e55ccbad4868a455c1c9f23e5f63bd99e916

Powered by Google App Engine
This is Rietveld 408576698