Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: pkg/compiler/lib/src/js_emitter/model.dart

Issue 1126423002: Avoid reparsing metadata expressions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index 7fa389bcc512e1a2160764999ad0fdea4820d8a3..69eb6aebc503284df2fc46b7d317585e2475016f 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -43,7 +43,7 @@ class Program {
assert(hasIsolateSupport != null);
}
- /// A list of pretty-printed JavaScript expressions.
+ /// A list of metadata expressions.
///
/// This list must be emitted in the `METADATA` embedded global.
/// The list references constants and must hence be emitted after constants
@@ -53,9 +53,9 @@ class Program {
/// list must not be emitted before all operations on it are done. For
/// example, the old emitter generates metadata when emitting reflection
/// data.
- List<String> get metadata => _metadataCollector.globalMetadata;
+ List<js.Expression> get metadata => _metadataCollector.globalMetadata;
- /// A map with lists of pretty-printed JavaScript expressions.
+ /// A map with lists of type expressions.
///
/// There is one list for each output unit. The list belonging to the main
/// unit must be emitted in the `TYPES` embedded global. The list references
@@ -65,7 +65,7 @@ class Program {
/// list must not be emitted before all operations on it are done. For
/// example, the old emitter generates metadata when emitting reflection
/// data.
- Map<OutputUnit, List<String>> get metadataTypes
+ Map<OutputUnit, List<js.Expression>> get metadataTypes
=> _metadataCollector.types;

Powered by Google App Engine
This is Rietveld 408576698