Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1126413009: Autofill: Fix some nits in autofill_controller.js. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Fix some nits in autofill_controller.js. Committed: https://crrev.com/0f3dfbe5de6a15a8a177700f23dcf0e52dfb5498 Cr-Commit-Position: refs/heads/master@{#329636}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -75 lines) Patch
M components/autofill/ios/browser/resources/autofill_controller.js View 1 40 chunks +76 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 7 months ago (2015-05-12 23:26:57 UTC) #2
Justin Donnelly
lgtm Wow, that's a lot of nits. :) Thanks.
5 years, 7 months ago (2015-05-13 14:33:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126413009/20001
5 years, 7 months ago (2015-05-13 14:34:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 14:41:20 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 14:42:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f3dfbe5de6a15a8a177700f23dcf0e52dfb5498
Cr-Commit-Position: refs/heads/master@{#329636}

Powered by Google App Engine
This is Rietveld 408576698