Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: client/crashpad_info.h

Issue 1126413008: win: Implement exception snapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: tidy Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/crashpad_info.h
diff --git a/client/crashpad_info.h b/client/crashpad_info.h
index 57ea4eb33af9e2613fbeb1b1c84fe9a95fe1b522..0e3017deb5467fc02fbc3c2ba0893c9620a78ae9 100644
--- a/client/crashpad_info.h
+++ b/client/crashpad_info.h
@@ -99,10 +99,15 @@ struct CrashpadInfo {
}
#if defined(OS_WIN)
+ //! \brief Save the crashing thread id for the crash handler.
Mark Mentovai 2015/08/18 16:17:19 Nit: ID.
scottmg 2015/08/18 16:56:00 Done.
+ void set_thread_id(DWORD thread_id) { thread_id_ = thread_id; }
+ DWORD thread_id() const { return thread_id_; }
+
//! \brief Save an EXCEPTION_POINTERS record for the crash handler.
Mark Mentovai 2015/08/18 16:17:19 Nit: `EXCEPTION_POINTERS`.
scottmg 2015/08/18 16:56:00 Done.
void set_exception_pointers(EXCEPTION_POINTERS* exception_pointers) {
exception_pointers_ = exception_pointers;
}
+ EXCEPTION_POINTERS* exception_pointers() const { return exception_pointers_; }
#endif // OS_WIN
enum : uint32_t {
@@ -129,6 +134,7 @@ struct CrashpadInfo {
SimpleStringDictionary* simple_annotations_; // weak
#if defined(OS_WIN)
+ DWORD thread_id_;
Mark Mentovai 2015/08/18 16:17:19 Organize for better packing: DWORDs follow pointer
scottmg 2015/08/18 16:56:00 Done.
EXCEPTION_POINTERS* exception_pointers_;
#endif // OS_WIN

Powered by Google App Engine
This is Rietveld 408576698