win: Implement exception snapshot

snapshot/win/process_snapshot_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "snapshot/win/process_snapshot_win.h"
 
 #include "snapshot/win/module_snapshot_win.h"
 #include "util/win/time.h"
 
 namespace crashpad {
 
 ProcessSnapshotWin::ProcessSnapshotWin()
     : ProcessSnapshot(),
       system_(),
       threads_(),
       modules_(),
-      // TODO(scottmg): exception_(),
+      exception_(),
       process_reader_(),
       report_id_(),
       client_id_(),
       annotations_simple_map_(),
       snapshot_time_(),
       initialized_() {
 }
 
 ProcessSnapshotWin::~ProcessSnapshotWin() {
 }
 
 bool ProcessSnapshotWin::Initialize(HANDLE process) {
   INITIALIZATION_STATE_SET_INITIALIZING(initialized_);
 
   GetTimeOfDay(&snapshot_time_);
 
   if (!process_reader_.Initialize(process))
     return false;
 
   system_.Initialize(&process_reader_);
 
   InitializeThreads();
   InitializeModules();
 
   INITIALIZATION_STATE_SET_VALID(initialized_);
   return true;
 }
 
+bool ProcessSnapshotWin::InitializeException(
+    DWORD thread_id,
+    WinVMAddress exception_pointers) {
+  INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+  DCHECK(!exception_);

[Mark Mentovai, 2015/08/18 16:17:20]

Can you add a logging.h #include to the Mac equivalent file too? Looks like it’s
missing, but it does the same thing.

[scottmg, 2015/08/18 16:56:00]

Mac looks correct to me? I added it here though.

[Mark Mentovai, 2015/08/18 17:52:13]

scottmg wrote:
I see process_snapshot_mac.cc using DCHECK() without #including logging.h.

[scottmg, 2015/08/18 18:18:20]

Oh, I must have been looking at exception_snapshot_mac.cc. Done.

+
+  exception_.reset(new internal::ExceptionSnapshotWin());
+  if (!exception_->Initialize(
+          &process_reader_, thread_id, exception_pointers)) {
+    exception_.reset();
+    return false;
+  }
+
+  return true;
+}
+
 void ProcessSnapshotWin::GetCrashpadOptions(
     CrashpadInfoClientOptions* options) {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
 
   CrashpadInfoClientOptions local_options;
 
   for (internal::ModuleSnapshotWin* module : modules_) {
     CrashpadInfoClientOptions module_options;
     module->GetCrashpadOptions(&module_options);
 
@@ skipping 76 matching lines @@
 std::vector<const ModuleSnapshot*> ProcessSnapshotWin::Modules() const {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
   std::vector<const ModuleSnapshot*> modules;
   for (internal::ModuleSnapshotWin* module : modules_) {
     modules.push_back(module);
   }
   return modules;
 }
 
 const ExceptionSnapshot* ProcessSnapshotWin::Exception() const {
-  CHECK(false) << "TODO(scottmg): Exception()";
-  return nullptr;
+  return exception_.get();
 }
 
 void ProcessSnapshotWin::InitializeThreads() {
   const std::vector<ProcessReaderWin::Thread>& process_reader_threads =
       process_reader_.Threads();
   for (const ProcessReaderWin::Thread& process_reader_thread :
        process_reader_threads) {
     auto thread = make_scoped_ptr(new internal::ThreadSnapshotWin());
     if (thread->Initialize(&process_reader_, process_reader_thread)) {
       threads_.push_back(thread.release());
     }
   }
 }
 
 void ProcessSnapshotWin::InitializeModules() {
   const std::vector<ProcessInfo::Module>& process_reader_modules =
       process_reader_.Modules();
   for (const ProcessInfo::Module& process_reader_module :
        process_reader_modules) {
     auto module = make_scoped_ptr(new internal::ModuleSnapshotWin());
     if (module->Initialize(&process_reader_, process_reader_module)) {
       modules_.push_back(module.release());
     }
   }
 }
 
 }  // namespace crashpad